Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Saturday, November 27, 2021 11:39 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for > subtitle handli

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Nicolas George
Anton Khirnov (12021-11-27): > > We should lock the library versions together so that we do not have to > > worry about the internal ABI. This is a problem we force on ourselves > > that brings very little benefit, probably benefit nobody actually cares > > about. > I disagree, as I'm sure you know

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Anton Khirnov
Quoting Nicolas George (2021-11-27 10:54:38) > Andreas Rheinhardt (12021-11-27): > >I actually > > had one more patchset that breaks the avpriv-ABI (i.e. it would not > > force user apps linking to our libs to be rebuilt; rebuilding the ff

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Saturday, November 27, 2021 10:55 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for > subtitle handling &g

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12021-11-27): >> I actually >> had one more patchset that breaks the avpriv-ABI (i.e. it would not >> force user apps linking to our libs to be rebuilt; rebuilding the ffmpeg >> libs is enough). Will s

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Nicolas George
Andreas Rheinhardt (12021-11-27): > I actually > had one more patchset that breaks the avpriv-ABI (i.e. it would not > force user apps linking to our libs to be rebuilt; rebuilding the ffmpeg > libs is enough). Will see how that fares. W

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Anton >> Khirnov >> Sent: Saturday, November 27, 2021 9:45 AM >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Anton Khirnov
Quoting Soft Works (2021-11-27 09:49:56) > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Anton > > Khirnov > > Sent: Saturday, November 27, 2021 9:45 AM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpe

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Saturday, November 27, 2021 9:45 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for > subtitle handling &g

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Saturday, November 27, 2021 9:45 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for > subtitle handling &g

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-27 Thread Anton Khirnov
Quoting Soft Works (2021-11-26 23:29:54) > > > This is breaking ABI. > > From earlier discussions, I think it's clear that the whole patchset cannot > go without breakage. Can you point me at the relevant arguments or restate them here? So far I see no fundamental reason why this needs to break

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-26 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Thursday, November 25, 2021 4:56 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for > subtitle handling > > Quoting Soft

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-26 Thread Anton Khirnov
Quoting Soft Works (2021-11-25 18:20:31) > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Anton > > Khirnov > > Sent: Thursday, November 25, 2021 4:56 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PA

[FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-25 Thread Soft Works
Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct AVSubt

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Thursday, November 25, 2021 4:56 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for > subtitle handling > > Quoting Soft

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-25 Thread Michael Niedermayer
On Thu, Nov 25, 2021 at 12:48:11AM +, Soft Works wrote: > Root commit for adding subtitle filtering capabilities. > In detail: > > - Add type (AVMediaType) field to AVFrame > Replaces previous way of distinction which was based on checking > width and height to determine whether a frame is

Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-25 Thread Anton Khirnov
Quoting Soft Works (2021-11-25 01:48:11) > Root commit for adding subtitle filtering capabilities. > In detail: > > - Add type (AVMediaType) field to AVFrame > Replaces previous way of distinction which was based on checking > width and height to determine whether a frame is audio or video > -

[FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for subtitle handling

2021-11-24 Thread Soft Works
Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct AVSubt