Re: [FFmpeg-devel] [PATCH v12] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-05 Thread Gautam Ramakrishnan
On Sun, Apr 5, 2020 at 3:13 PM Moritz Barsnick wrote: > > On Sun, Apr 05, 2020 at 10:28:17 +0530, gautamr...@gmail.com wrote: > > +tile->has_ppt = 1; // this tile has a ppt marker > > +/*Zppt = */ bytestream2_get_byte(&s->g); // Zppt is skipped and not > > used > > I don't know what othe

Re: [FFmpeg-devel] [PATCH v12] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-05 Thread Moritz Barsnick
On Sun, Apr 05, 2020 at 10:28:17 +0530, gautamr...@gmail.com wrote: > +tile->has_ppt = 1; // this tile has a ppt marker > +/*Zppt = */ bytestream2_get_byte(&s->g); // Zppt is skipped and not used I don't know what others think, but, as mentioned in my first review, I really dislike this s

[FFmpeg-devel] [PATCH v12] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-04 Thread gautamramk
From: Gautam Ramakrishnan This patch adds functional changes to support the PPT marker. This patch fixes bug ticket #4610. --- libavcodec/jpeg2000dec.c | 88 +++- 1 file changed, 77 insertions(+), 11 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavc