Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
> 2020年3月29日 下午4:32,Steven Liu 写道: > > >> 2020年3月26日 下午9:57,lance.lmw...@gmail.com 写道: >> >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavformat/hlsenc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/libavformat/hlsenc.c b/libavformat/hls

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
> 2020年4月8日 下午10:48,Nicolas George 写道: > > Steven Liu (12020-04-08): >> I cannot get the mean of BPrint where should or when should use it, maybe >> you can introduce it, >> I always think BPrint is used to instead of av_[a]sprintf, >> because I saw mkver submit 3 patches to modify from snpri

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Nicolas George
Steven Liu (12020-04-08): > I cannot get the mean of BPrint where should or when should use it, maybe you > can introduce it, > I always think BPrint is used to instead of av_[a]sprintf, > because I saw mkver submit 3 patches to modify from snprintf to BPrint BPrint brings three benefits: - It

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年3月26日 下午9:57,lance.lmw...@gmail.com 写道: >> >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavformat/hlsenc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c >> index d7b9c0e20a..69

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
> 2020年4月8日 下午10:32,Nicolas George 写道: > > Steven Liu (12020-04-08): >> As mkver suggestion, perhaps use bprint is better, is it? > > It does not seem like a situation where BPrint is beneficial. I cannot get the mean of BPrint where should or when should use it, maybe you can introduce it,

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Nicolas George
Steven Liu (12020-04-08): > As mkver suggestion, perhaps use bprint is better, is it? It does not seem like a situation where BPrint is beneficial. Other filename handling functions in this HLS code would, though. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
> 2020年3月26日 下午9:57,lance.lmw...@gmail.com 写道: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/hlsenc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index d7b9c0e20a..694dab42dd 100644 > --- a/

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-03-29 Thread Steven Liu
> 2020年3月26日 下午9:57,lance.lmw...@gmail.com 写道: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/hlsenc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index d7b9c0e20a..694dab42dd 100644 > --- a/

[FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-03-26 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index d7b9c0e20a..694dab42dd 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2950,13 +2950,11 @