Re: [FFmpeg-devel] [PATCH V2 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-26 Thread Tyler Jones
On Wed, Jul 26, 2017 at 12:51:31AM +0100, Rostislav Pehlivanov wrote: > On 17 July 2017 at 16:17, Tyler Jones wrote: > > > +float last_var; > > +const float eps = 1e-4; > > > > Use normal notation for floats and add an f at the end to inform the > compiler the constant is a float. Fixed

Re: [FFmpeg-devel] [PATCH V2 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-26 Thread Moritz Barsnick
On Wed, Jul 26, 2017 at 00:51:31 +0100, Rostislav Pehlivanov wrote: > > +float last_var; > > +const float eps = 1e-4; > > Use normal notation for floats and add an f at the end to inform the > compiler the constant is a float. Since I've been nitpicking float/double promotion issues recen

Re: [FFmpeg-devel] [PATCH V2 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-25 Thread Rostislav Pehlivanov
On 17 July 2017 at 16:17, Tyler Jones wrote: > The encoder will attempt to determine the existence of transient > signals by applying a 4th order highpass filter to remove dominant > low frequency waveforms. Frames are then split up into blocks > where the variance is calculated and compared with

Re: [FFmpeg-devel] [PATCH V2 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-21 Thread Tyler Jones
On Mon, Jul 17, 2017 at 09:17:09AM -0600, Tyler Jones wrote: > The encoder will attempt to determine the existence of transient > signals by applying a 4th order highpass filter to remove dominant > low frequency waveforms. Frames are then split up into blocks > where the variance is calculated and

[FFmpeg-devel] [PATCH V2 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-17 Thread Tyler Jones
The encoder will attempt to determine the existence of transient signals by applying a 4th order highpass filter to remove dominant low frequency waveforms. Frames are then split up into blocks where the variance is calculated and compared with blocks from the previous frame. A preecho is only like