Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-23 Thread Zhong Li
James Almer 于2019年12月23日周一 下午9:09写道： > > On 12/23/2019 9:31 AM, Zhong Li wrote: > > James Almer 于2019年12月22日周日 下午11:29写道： > >> > >> On 12/22/2019 12:26 PM, Zhong Li wrote: > >>> Signed-off-by: Zhong Li > >>> --- > >>> libavcodec/midivid.c | 9 ++--- > >>> 1 file changed, 6 insertions(+), 3

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-23 Thread James Almer
On 12/23/2019 9:31 AM, Zhong Li wrote: > James Almer 于2019年12月22日周日 下午11:29写道： >> >> On 12/22/2019 12:26 PM, Zhong Li wrote: >>> Signed-off-by: Zhong Li >>> --- >>> libavcodec/midivid.c | 9 ++--- >>> 1 file changed, 6 insertions(+), 3 deletions(-) >>> >>> diff --git a/libavcodec/midivid.c b

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-23 Thread Paul B Mahol
On 12/22/19, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > libavcodec/midivid.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c > index 38465c5..3dac3f1 100644 > --- a/libavcodec/midivid.c > +++ b/libavcodec/midivi

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-23 Thread Zhong Li
James Almer 于2019年12月22日周日 下午11:29写道： > > On 12/22/2019 12:26 PM, Zhong Li wrote: > > Signed-off-by: Zhong Li > > --- > > libavcodec/midivid.c | 9 ++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c > > index 38465c5..3d

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-23 Thread Nicolas George
Zhong Li (12019-12-23): > > Then review that ret needs to be returned ;-) It needs more change, not > > less. > > Could specify what "more change" is needed? See above, I underlined it. Regards, -- Nicolas George signature.asc Description: PGP

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-23 Thread Zhong Li
Nicolas George 于2019年12月23日周一 下午5:00写道： > > Limin Wang (12019-12-23): > > But It's not my code, I'm a code reviewer. > > Then review that ret needs to be returned ;-) It needs more change, not > less. Could specify what "more change" is needed? ___ ffmp

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-23 Thread Nicolas George
Limin Wang (12019-12-23): > But It's not my code, I'm a code reviewer. Then review that ret needs to be returned ;-) It needs more change, not less. And the commit message needs to be explicit. CID may not be available everywhere or everywhen. Regards, -- Nicolas George signature.asc Descr

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Andreas Rheinhardt
On Mon, Dec 23, 2019 at 6:03 AM Limin Wang wrote: > On Mon, Dec 23, 2019 at 02:00:10AM +0100, Andreas Rheinhardt wrote: > > On Mon, Dec 23, 2019 at 1:53 AM Limin Wang > wrote: > > > > > On Sun, Dec 22, 2019 at 03:26:58PM +, Zhong Li wrote: > > > > Signed-off-by: Zhong Li > > > > --- > > > >

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Limin Wang
On Mon, Dec 23, 2019 at 02:00:10AM +0100, Andreas Rheinhardt wrote: > On Mon, Dec 23, 2019 at 1:53 AM Limin Wang wrote: > > > On Sun, Dec 22, 2019 at 03:26:58PM +, Zhong Li wrote: > > > Signed-off-by: Zhong Li > > > --- > > > libavcodec/midivid.c | 9 ++--- > > > 1 file changed, 6 inser

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Andreas Rheinhardt
On Mon, Dec 23, 2019 at 1:53 AM Limin Wang wrote: > On Sun, Dec 22, 2019 at 03:26:58PM +, Zhong Li wrote: > > Signed-off-by: Zhong Li > > --- > > libavcodec/midivid.c | 9 ++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/libavcodec/midivid.c b/libavcodec/mi

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Limin Wang
On Sun, Dec 22, 2019 at 03:26:58PM +, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > libavcodec/midivid.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c > index 38465c5..3dac3f1 100644 > --- a/libavcodec/midivi

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread James Almer
On 12/22/2019 12:26 PM, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > libavcodec/midivid.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c > index 38465c5..3dac3f1 100644 > --- a/libavcodec/midivid.c > +++ b/libavc

[FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/midivid.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c index 38465c5..3dac3f1 100644 --- a/libavcodec/midivid.c +++ b/libavcodec/midivid.c @@ -63,17 +63,20 @@ static int decode_mvdv(