Re: [FFmpeg-devel] [PATCH 7/7] mlp: check huff_lsbs only when codebook is used

2020-02-06 Thread Michael Niedermayer
On Thu, Feb 06, 2020 at 02:59:03PM +0530, Jai Luthra wrote: > On Tue, Feb 04, 2020 at 10:24:50PM +0100, Michael Niedermayer wrote: > >On Mon, Feb 03, 2020 at 12:33:00AM +0530, Jai Luthra wrote: > >>When no codebook is used, huff_lsbs can be more than 24 and still decode to > >>original values once

Re: [FFmpeg-devel] [PATCH 7/7] mlp: check huff_lsbs only when codebook is used

2020-02-06 Thread Jai Luthra
On Tue, Feb 04, 2020 at 10:24:50PM +0100, Michael Niedermayer wrote: On Mon, Feb 03, 2020 at 12:33:00AM +0530, Jai Luthra wrote: When no codebook is used, huff_lsbs can be more than 24 and still decode to original values once filters are applied. huff_lsbs can but get_bits() is limited to 25,

Re: [FFmpeg-devel] [PATCH 7/7] mlp: check huff_lsbs only when codebook is used

2020-02-04 Thread Michael Niedermayer
On Mon, Feb 03, 2020 at 12:33:00AM +0530, Jai Luthra wrote: > When no codebook is used, huff_lsbs can be more than 24 and still decode to > original values once filters are applied. huff_lsbs can but get_bits() is limited to 25, you need get_bits_long() beyond thx [...] -- Michael GnuPG fi

[FFmpeg-devel] [PATCH 7/7] mlp: check huff_lsbs only when codebook is used

2020-02-02 Thread Jai Luthra
When no codebook is used, huff_lsbs can be more than 24 and still decode to original values once filters are applied. Signed-off-by: Jai Luthra --- libavcodec/mlpdec.c | 2 +- libavcodec/mlpenc.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) Fixes lossless check failures caused with