Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread Timothy Gu
Actually GCC is too dumb. There is literally no way to "fix" this in a clean way. Patch dropped. On Fri Feb 06 2015 at 7:57:33 PM Timothy Gu wrote: > On Fri Feb 06 2015 at 7:55:31 PM Timothy Gu wrote: > >> On Fri Feb 06 2015 at 7:44:23 PM Michael Niedermayer >> wrote: >> >>> On Fri, Feb 06, 20

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread Timothy Gu
On Fri Feb 06 2015 at 7:55:31 PM Timothy Gu wrote: > On Fri Feb 06 2015 at 7:44:23 PM Michael Niedermayer > wrote: > >> On Fri, Feb 06, 2015 at 07:32:56AM +, Timothy Gu wrote: >> > On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu >> wrote: >> > >> > > (num_quant_units - 1) is later used as an i

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread Timothy Gu
On Fri Feb 06 2015 at 7:44:23 PM Michael Niedermayer wrote: > On Fri, Feb 06, 2015 at 07:32:56AM +, Timothy Gu wrote: > > On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu > wrote: > > > > > (num_quant_units - 1) is later used as an index to > atrac3p_qu_to_subband, > > > which only has 32 elemen

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 07:32:56AM +, Timothy Gu wrote: > On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu wrote: > > > (num_quant_units - 1) is later used as an index to atrac3p_qu_to_subband, > > which only has 32 elements (i.e. maximum of num_quant_units is 32). > > --- > > libavcodec/atrac3p

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread Timothy Gu
On Fri Feb 06 2015 at 2:58:19 AM wm4 wrote: > On Fri, 06 Feb 2015 07:32:56 + > Timothy Gu wrote: > > > On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu > wrote: > > > > > (num_quant_units - 1) is later used as an index to > atrac3p_qu_to_subband, > > > which only has 32 elements (i.e. maximum o

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread wm4
On Fri, 06 Feb 2015 07:32:56 + Timothy Gu wrote: > On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu wrote: > > > (num_quant_units - 1) is later used as an index to atrac3p_qu_to_subband, > > which only has 32 elements (i.e. maximum of num_quant_units is 32). > > --- > > libavcodec/atrac3plus.c

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-05 Thread Timothy Gu
On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu wrote: > (num_quant_units - 1) is later used as an index to atrac3p_qu_to_subband, > which only has 32 elements (i.e. maximum of num_quant_units is 32). > --- > libavcodec/atrac3plus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Note th

[FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-05 Thread Timothy Gu
(num_quant_units - 1) is later used as an index to atrac3p_qu_to_subband, which only has 32 elements (i.e. maximum of num_quant_units is 32). --- libavcodec/atrac3plus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/atrac3plus.c b/libavcodec/atrac3plus.c index 575a