Re: [FFmpeg-devel] [PATCH 6/9] vp9: add keyframe profile 2/3 support.

2015-05-07 Thread wm4
On Wed, 6 May 2015 17:40:20 + (UTC) Carl Eugen Hoyos wrote: > Ronald S. Bultje gmail.com> writes: > > > +static void vert_4x4_c(uint8_t *_dst, ptrdiff_t stride, > > + const uint8_t *left, const uint8_t *_top) > > Once upon a time, it was claimed that we must not > us

Re: [FFmpeg-devel] [PATCH 6/9] vp9: add keyframe profile 2/3 support.

2015-05-06 Thread Carl Eugen Hoyos
Ronald S. Bultje gmail.com> writes: > upper bits are zero in libvpx, so it uses formats > that are analogous to our p10/p12 pixfmts. It > (confusingly) calls the formats p16 in its internal > API, and sets bits_per_sample, but this has the exact > opposite meaning of what it means in ffmpeg..

Re: [FFmpeg-devel] [PATCH 6/9] vp9: add keyframe profile 2/3 support.

2015-05-06 Thread Ronald S. Bultje
Hi, On Wed, May 6, 2015 at 4:28 PM, Carl Eugen Hoyos wrote: > Ronald S. Bultje gmail.com> writes: > > > > I still wonder if it was a good idea to add the > > > formats >8 and <16... > > > > I think the biggest issue with going with 16 and > > using bits_per_coded_sample, is to enforce that > >

Re: [FFmpeg-devel] [PATCH 6/9] vp9: add keyframe profile 2/3 support.

2015-05-06 Thread Carl Eugen Hoyos
Ronald S. Bultje gmail.com> writes: > > I still wonder if it was a good idea to add the > > formats >8 and <16... > > I think the biggest issue with going with 16 and > using bits_per_coded_sample, is to enforce that > the lowest bits are actually zero. I think this shouldn't be enforced. Ii

Re: [FFmpeg-devel] [PATCH 6/9] vp9: add keyframe profile 2/3 support.

2015-05-06 Thread Ronald S. Bultje
Hi, On Wed, May 6, 2015 at 2:00 PM, Carl Eugen Hoyos wrote: > Ronald S. Bultje gmail.com> writes: > > > Overall, the effect would be minor, like in the lower > > single-digit percents or perhaps even fractional percent, > > but I would absolutely expect a small performance gain > > from using p

Re: [FFmpeg-devel] [PATCH 6/9] vp9: add keyframe profile 2/3 support.

2015-05-06 Thread Carl Eugen Hoyos
Ronald S. Bultje gmail.com> writes: > Overall, the effect would be minor, like in the lower > single-digit percents or perhaps even fractional percent, > but I would absolutely expect a small performance gain > from using p10/p12 over p16 w/ bits_per_coded_sample. > Also note most of this wou

Re: [FFmpeg-devel] [PATCH 6/9] vp9: add keyframe profile 2/3 support.

2015-05-06 Thread Ronald S. Bultje
Hi, On Wed, May 6, 2015 at 1:40 PM, Carl Eugen Hoyos wrote: > Ronald S. Bultje gmail.com> writes: > > +static void vert_4x4_c(uint8_t *_dst, ptrdiff_t stride, > > + const uint8_t *left, const uint8_t *_top) > > Once upon a time, it was claimed that we must not > use identif

Re: [FFmpeg-devel] [PATCH 6/9] vp9: add keyframe profile 2/3 support.

2015-05-06 Thread Carl Eugen Hoyos
Ronald S. Bultje gmail.com> writes: > +static void vert_4x4_c(uint8_t *_dst, ptrdiff_t stride, > + const uint8_t *left, const uint8_t *_top) Once upon a time, it was claimed that we must not use identifiers starting with "_". Would it be slower to decode to YUV420P16 and