Re: [FFmpeg-devel] [PATCH 6/9] avcodec/libvpxenc: Cleanup on error

2024-06-19 Thread Michael Niedermayer
On Mon, Jun 17, 2024 at 10:10:38AM -0700, James Zern via ffmpeg-devel wrote: > On Sun, Jun 16, 2024 at 4:09 PM Michael Niedermayer > wrote: > > > > This or fifo needs to be freed on errors explicitly > > I have not verified that its always safe to call vpx_free() this needs to > > be checked befo

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/libvpxenc: Cleanup on error

2024-06-17 Thread James Zern via ffmpeg-devel
On Sun, Jun 16, 2024 at 4:09 PM Michael Niedermayer wrote: > > This or fifo needs to be freed on errors explicitly > I have not verified that its always safe to call vpx_free() this needs to be > checked before applying this > It should be safe to call into libvpx whether the encoder init succee

[FFmpeg-devel] [PATCH 6/9] avcodec/libvpxenc: Cleanup on error

2024-06-16 Thread Michael Niedermayer
This or fifo needs to be freed on errors explicitly I have not verified that its always safe to call vpx_free() this needs to be checked before applying this Fixes: memleak Fixes: 68937/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVPX_VP8_fuzzer-4830831016214528 Found-by: continuous fuz