Re: [FFmpeg-devel] [PATCH 6/8] lavf/http: Implement server side network code.

2015-07-28 Thread Nicolas George
Le decadi 10 thermidor, an CCXXIII, Stephan Holljes a écrit : > I thought it was necessary for the application to indicate it wants to > finish the handshake. I think with the FINAL state this is > superfluous. Eventually, applications must be able to choose, but the default can be anything, and s

[FFmpeg-devel] [PATCH 6/8] lavf/http: Implement server side network code.

2015-07-27 Thread Stephan Holljes
add http_accept, add http_handshake and move handshake logic there, handle connection closing. Signed-off-by: Stephan Holljes --- libavformat/http.c | 182 ++--- 1 file changed, 158 insertions(+), 24 deletions(-) Changes since last version: - Use

Re: [FFmpeg-devel] [PATCH 6/8] lavf/http: Implement server side network code.

2015-07-27 Thread Stephan Holljes
On Sat, Jul 25, 2015 at 5:04 PM, Nicolas George wrote: > Le septidi 7 thermidor, an CCXXIII, Stephan Holljes a écrit : >> Attached patch fixes a bug where a oneshot server would not finish a >> handshake, because s->handshake_finish was not set. > > Thanks for the patch series. I have no remarks a

Re: [FFmpeg-devel] [PATCH 6/8] lavf/http: Implement server side network code.

2015-07-25 Thread Nicolas George
Le septidi 7 thermidor, an CCXXIII, Stephan Holljes a écrit : > Attached patch fixes a bug where a oneshot server would not finish a > handshake, because s->handshake_finish was not set. Thanks for the patch series. I have no remarks about 1-5 and 7, except for one point of API that I will discuss

Re: [FFmpeg-devel] [PATCH 6/8] lavf/http: Implement server side network code.

2015-07-24 Thread Stephan Holljes
Attached patch fixes a bug where a oneshot server would not finish a handshake, because s->handshake_finish was not set. Regards, Stephan From fb3cc42c64cc4f9e26dc305e2a3f6aacd6f7a001 Mon Sep 17 00:00:00 2001 From: Stephan Holljes Date: Fri, 3 Jul 2015 02:28:56 +0200 Subject: [PATCH 6/8] lavf/htt

[FFmpeg-devel] [PATCH 6/8] lavf/http: Implement server side network code.

2015-07-24 Thread Stephan Holljes
add http_accept, add http_handshake and move handshake logic there, handle connection closing. Signed-off-by: Stephan Holljes --- libavformat/http.c | 184 ++--- 1 file changed, 161 insertions(+), 23 deletions(-) Changes since last version: - Add