Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 01:03:35PM +0200, wm4 wrote: > On Fri, 25 Aug 2017 11:59:54 +0200 > Michael Niedermayer wrote: > > > On Fri, Aug 25, 2017 at 10:08:23AM +0200, wm4 wrote: > > > On Fri, 25 Aug 2017 01:15:32 +0200 > > > Michael Niedermayer wrote: > > > > > > > Fixes: loop.m3u > > > > >

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread wm4
On Fri, 25 Aug 2017 11:59:54 +0200 Michael Niedermayer wrote: > On Fri, Aug 25, 2017 at 10:08:23AM +0200, wm4 wrote: > > On Fri, 25 Aug 2017 01:15:32 +0200 > > Michael Niedermayer wrote: > > > > > Fixes: loop.m3u > > > > > > The max iteration count of 1 is arbitrary and ideas for a bette

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 08:23:32AM +0800, Steven Liu wrote: > 2017-08-25 7:15 GMT+08:00 Michael Niedermayer : > > Fixes: loop.m3u > > > > The max iteration count of 1 is arbitrary and ideas for a better > > solution are welcome > Why not give a option to user for set the reload_count and limit

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 10:08:23AM +0200, wm4 wrote: > On Fri, 25 Aug 2017 01:15:32 +0200 > Michael Niedermayer wrote: > > > Fixes: loop.m3u > > > > The max iteration count of 1 is arbitrary and ideas for a better > > solution are welcome > > > > Found-by: Xiaohei and Wangchu from Alibaba

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread wm4
On Fri, 25 Aug 2017 01:15:32 +0200 Michael Niedermayer wrote: > Fixes: loop.m3u > > The max iteration count of 1 is arbitrary and ideas for a better solution > are welcome > > Found-by: Xiaohei and Wangchu from Alibaba Security Team > Signed-off-by: Michael Niedermayer > --- > libavforma

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-24 Thread Steven Liu
2017-08-25 7:15 GMT+08:00 Michael Niedermayer : > Fixes: loop.m3u > > The max iteration count of 1 is arbitrary and ideas for a better solution > are welcome Why not give a option to user for set the reload_count and limit from 1 - 1? > > Found-by: Xiaohei and Wangchu from Alibaba Securit

[FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-24 Thread Michael Niedermayer
Fixes: loop.m3u The max iteration count of 1 is arbitrary and ideas for a better solution are welcome Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer --- libavformat/hls.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/hls.c