Re: [FFmpeg-devel] [PATCH 5/7] mxfdec: Fix return value check

2017-10-18 Thread Michael Niedermayer
On Tue, Oct 17, 2017 at 11:11:57PM +0100, Mark Thompson wrote: > Move the assignment out of the condition, because that was hiding the error. > > Fixes #6750. > --- > libavformat/mxfdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint

[FFmpeg-devel] [PATCH 5/7] mxfdec: Fix return value check

2017-10-17 Thread Mark Thompson
Move the assignment out of the condition, because that was hiding the error. Fixes #6750. --- libavformat/mxfdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 118e3e40b4..e4019ac0a7 100644 --- a/libavformat/mxfdec.c +++ b