Re: [FFmpeg-devel] [PATCH 5/6] avformat/mux: Don't modify packets we don't own

2020-04-16 Thread Marton Balint
On Thu, 16 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: On Sat, 11 Apr 2020, Andreas Rheinhardt wrote: The documentation of av_write_frame() explicitly states that the function doesn't take ownership of the packets sent to it; while av_write_frame() does not directly unreference the

Re: [FFmpeg-devel] [PATCH 5/6] avformat/mux: Don't modify packets we don't own

2020-04-16 Thread Andreas Rheinhardt
Marton Balint: > > > On Sat, 11 Apr 2020, Andreas Rheinhardt wrote: > >> The documentation of av_write_frame() explicitly states that the function >> doesn't take ownership of the packets sent to it; while av_write_frame() >> does not directly unreference the packets after having written them, i

Re: [FFmpeg-devel] [PATCH 5/6] avformat/mux: Don't modify packets we don't own

2020-04-16 Thread Marton Balint
On Sat, 11 Apr 2020, Andreas Rheinhardt wrote: The documentation of av_write_frame() explicitly states that the function doesn't take ownership of the packets sent to it; while av_write_frame() does not directly unreference the packets after having written them, it nevertheless modifies the pa

[FFmpeg-devel] [PATCH 5/6] avformat/mux: Don't modify packets we don't own

2020-04-11 Thread Andreas Rheinhardt
The documentation of av_write_frame() explicitly states that the function doesn't take ownership of the packets sent to it; while av_write_frame() does not directly unreference the packets after having written them, it nevertheless modifies the packet in various ways: 1. The timestamps might be mod