Re: [FFmpeg-devel] [PATCH 5/5 v2] avformat: add an AV1 Annex B demuxer

2019-11-12 Thread Ronald S. Bultje
Hi, On Tue, Nov 12, 2019 at 8:09 AM James Almer wrote: > On 11/12/2019 2:52 AM, Ronald S. Bultje wrote: > > Hi, > > > > On Mon, Nov 11, 2019 at 9:17 PM James Almer wrote: > > > >> +static int leb(AVIOContext *pb, uint32_t *len) { > >> > > > > this can overflow, should be uint64_t. > > > > > >>

Re: [FFmpeg-devel] [PATCH 5/5 v2] avformat: add an AV1 Annex B demuxer

2019-11-12 Thread James Almer
On 11/12/2019 2:52 AM, Ronald S. Bultje wrote: > Hi, > > On Mon, Nov 11, 2019 at 9:17 PM James Almer wrote: > >> +static int leb(AVIOContext *pb, uint32_t *len) { >> > > this can overflow, should be uint64_t. > > >> +unsigned bits; >> > > Same. > > Ronald I used the same method as

Re: [FFmpeg-devel] [PATCH 5/5 v2] avformat: add an AV1 Annex B demuxer

2019-11-11 Thread Ronald S. Bultje
Hi, On Mon, Nov 11, 2019 at 9:17 PM James Almer wrote: > +static int leb(AVIOContext *pb, uint32_t *len) { > this can overflow, should be uint64_t. > +unsigned bits; > Same. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org htt

[FFmpeg-devel] [PATCH 5/5 v2] avformat: add an AV1 Annex B demuxer

2019-11-11 Thread James Almer
Signed-off-by: James Almer --- configure| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/obu.c| 277 +++ 4 files changed, 280 insertions(+) create mode 100644 libavformat/obu.c diff --git a/confi