Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-23 Thread Michael Niedermayer
On Tue, Oct 22, 2024 at 04:22:06PM +0200, Lynne via ffmpeg-devel wrote: > On 16/10/2024 15:26, Michael Niedermayer wrote: > > This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression > > with rawlsb=4 > > > > Please test and comment > > > > This stores the LSB through non binary

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-22 Thread Lynne via ffmpeg-devel
On 16/10/2024 15:26, Michael Niedermayer wrote: This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression with rawlsb=4 Please test and comment This stores the LSB through non binary range coding, this is simpler than using a separate coder For cases where range coding is not w

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-22 Thread Michael Niedermayer
On Mon, Oct 21, 2024 at 04:40:41PM +0200, Jerome Martinez wrote: > Le 16/10/2024 à 22:53, Michael Niedermayer a écrit : > > what are you testing? > > the new code is faster than the old code. > > There is something not right here, the range coder based implementation > > i posted now is 5% faster t

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-21 Thread Jerome Martinez
Le 16/10/2024 à 22:53, Michael Niedermayer a écrit : what are you testing? the new code is faster than the old code. There is something not right here, the range coder based implementation i posted now is 5% faster then the range coder based one i posted earlier today thats overall speed meassure

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
On Wed, Oct 16, 2024 at 10:53:37PM +0200, Michael Niedermayer wrote: > Hi Jerome > > On Wed, Oct 16, 2024 at 10:29:18PM +0200, Jerome Martinez wrote: > > Le 16/10/2024 à 21:51, Michael Niedermayer a écrit : > > > did you try qtable 1 ? strangely it performed better for the file i used > > > compr

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
Hi Jerome On Wed, Oct 16, 2024 at 10:29:18PM +0200, Jerome Martinez wrote: > Le 16/10/2024 à 21:51, Michael Niedermayer a écrit : > > did you try qtable 1 ? strangely it performed better for the file i used > > compression wise > > Updated with latest code (in practice, no change in previous val

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Jerome Martinez
Le 16/10/2024 à 21:51, Michael Niedermayer a écrit : did you try qtable 1 ? strangely it performed better for the file i used compression wise Updated with latest code (in practice, no change in previous values): 0,037x    0,471    No patch 0,051x    0,491    bitfield 0,046x    0,489    rangec

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
Hi Jerome On Wed, Oct 16, 2024 at 06:27:09PM +0200, Jerome Martinez wrote: > Le 16/10/2024 à 15:54, Michael Niedermayer a écrit : > > 3rd implemantation :) > > you might ask why i implement this 4?! times > > Heres why: (tests done with 4 rawlsb bits, 16bit per sample input) > > I tested on my si

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Jerome Martinez
Le 16/10/2024 à 15:54, Michael Niedermayer a écrit : 3rd implemantation :) you might ask why i implement this 4?! times Heres why: (tests done with 4 rawlsb bits, 16bit per sample input) I tested on my side also including the speed as the goal is to avoid the speed cost of the LSB, with 6K con

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
On Wed, Oct 16, 2024 at 03:26:39PM +0200, Michael Niedermayer wrote: > This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression with > rawlsb=4 > > Please test and comment > > This stores the LSB through non binary range coding, this is simpler than > using a > separate coder >

[FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression with rawlsb=4 Please test and comment This stores the LSB through non binary range coding, this is simpler than using a separate coder For cases where range coding is not wanted its probably best to use golomb rice for eve