Re: [FFmpeg-devel] [PATCH 5/5] lavfi: make request_frame() non-recursive.

2015-12-01 Thread Ganesh Ajjanagadde
On Tue, Dec 1, 2015 at 11:26 AM, Nicolas George wrote: > Le decadi 10 frimaire, an CCXXIV, Hendrik Leppkes a écrit : >> We generally just use ints for boolean properties, any particular >> reason this uses unsigned instead? > > Just a matter of personal habit, justified below. But as I look at it,

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: make request_frame() non-recursive.

2015-12-01 Thread Clément Bœsch
On Tue, Dec 01, 2015 at 05:26:23PM +0100, Nicolas George wrote: > Le decadi 10 frimaire, an CCXXIV, Hendrik Leppkes a écrit : > > We generally just use ints for boolean properties, any particular > > reason this uses unsigned instead? > > Just a matter of personal habit, justified below. But as I

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: make request_frame() non-recursive.

2015-12-01 Thread Nicolas George
Le decadi 10 frimaire, an CCXXIV, Hendrik Leppkes a écrit : > We generally just use ints for boolean properties, any particular > reason this uses unsigned instead? Just a matter of personal habit, justified below. But as I look at it, I see it is rather inconsistent with other fields in the struc

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: make request_frame() non-recursive.

2015-11-30 Thread Hendrik Leppkes
On Sun, Nov 29, 2015 at 5:21 PM, Nicolas George wrote: > Instead of calling the input filter request_frame() method, > ff_request_frame() now marks the link and returns immediately. > bufferskin is changed to activate the marked filters until > a frame is obtained. > > Signed-off-by: Nicolas Georg

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: make request_frame() non-recursive.

2015-11-30 Thread Michael Niedermayer
On Sun, Nov 29, 2015 at 05:21:52PM +0100, Nicolas George wrote: > Instead of calling the input filter request_frame() method, > ff_request_frame() now marks the link and returns immediately. > bufferskin is changed to activate the marked filters until sink didnt review the rest (migh

[FFmpeg-devel] [PATCH 5/5] lavfi: make request_frame() non-recursive.

2015-11-29 Thread Nicolas George
Instead of calling the input filter request_frame() method, ff_request_frame() now marks the link and returns immediately. bufferskin is changed to activate the marked filters until a frame is obtained. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 20 +++- libavfil