Re: [FFmpeg-devel] [PATCH 5/5] avformat: add amv muxer

2020-11-02 Thread Andreas Rheinhardt
Zane van Iperen: > On 2/11/20 7:47 pm, Andreas Rheinhardt wrote: > >>> +if (pkt->stream_index == AMV_STREAM_VIDEO) { >>> +/* Save the last packet for padding. */ >>> +av_packet_unref(&amv->vpad); >>> +av_packet_ref(&amv->vpad, pkt); >> >> Missing check. >> > For what sp

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add amv muxer

2020-11-02 Thread Zane van Iperen
On 2/11/20 7:47 pm, Andreas Rheinhardt wrote: >> +if (pkt->stream_index == AMV_STREAM_VIDEO) { >> +/* Save the last packet for padding. */ >> +av_packet_unref(&amv->vpad); >> +av_packet_ref(&amv->vpad, pkt); > > Missing check. > For what specifically? Afaics av_buffer

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add amv muxer

2020-11-02 Thread Andreas Rheinhardt
Zane van Iperen: > AMV is a hard-coded (and broken) subset of AVI. It's not worth sullying > the existing AVI muxer with its filth. > > Fixes ticket #747. > > Signed-off-by: Zane van Iperen > --- > MAINTAINERS | 1 + > libavformat/Makefile | 1 + > libavformat/allformats.c

[FFmpeg-devel] [PATCH 5/5] avformat: add amv muxer

2020-11-02 Thread Zane van Iperen
AMV is a hard-coded (and broken) subset of AVI. It's not worth sullying the existing AVI muxer with its filth. Fixes ticket #747. Signed-off-by: Zane van Iperen --- MAINTAINERS | 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/amvenc.c | 4