Re: [FFmpeg-devel] [PATCH 5/5] avformat/movenc: add support for AV1 streams

2018-07-12 Thread James Almer
On 7/12/2018 9:29 PM, Michael Niedermayer wrote: > On Thu, Jul 12, 2018 at 10:59:44AM -0300, James Almer wrote: >> On 7/12/2018 8:26 AM, Michael Niedermayer wrote: >>> On Mon, Jul 09, 2018 at 03:26:54PM -0300, James Almer wrote: Signed-off-by: James Almer --- ff_av1_filter_obus() co

Re: [FFmpeg-devel] [PATCH 5/5] avformat/movenc: add support for AV1 streams

2018-07-12 Thread Michael Niedermayer
On Thu, Jul 12, 2018 at 10:59:44AM -0300, James Almer wrote: > On 7/12/2018 8:26 AM, Michael Niedermayer wrote: > > On Mon, Jul 09, 2018 at 03:26:54PM -0300, James Almer wrote: > >> Signed-off-by: James Almer > >> --- > >> ff_av1_filter_obus() could eventually be replaced by an autoinserted > >> f

Re: [FFmpeg-devel] [PATCH 5/5] avformat/movenc: add support for AV1 streams

2018-07-12 Thread James Almer
On 7/12/2018 8:26 AM, Michael Niedermayer wrote: > On Mon, Jul 09, 2018 at 03:26:54PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> ff_av1_filter_obus() could eventually be replaced by an autoinserted >> filter_units bsf, assuming it doesn't slow down the muxing process >> too

Re: [FFmpeg-devel] [PATCH 5/5] avformat/movenc: add support for AV1 streams

2018-07-12 Thread Michael Niedermayer
On Mon, Jul 09, 2018 at 03:26:54PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > ff_av1_filter_obus() could eventually be replaced by an autoinserted > filter_units bsf, assuming it doesn't slow down the muxing process > too much (CBS is fast reading packets, but not so much assem

Re: [FFmpeg-devel] [PATCH 5/5] avformat/movenc: add support for AV1 streams

2018-07-09 Thread Hendrik Leppkes
On Tue, Jul 10, 2018 at 12:29 AM Baptiste Coudurier wrote: > > Hi James, > > On Mon, Jul 9, 2018 at 11:26 AM, James Almer wrote: > > [...] > > > > @@ -5438,7 +5461,7 @@ int ff_mov_write_packet(AVFormatContext *s, > > AVPacket *pkt) > > av_log(s, AV_LOG_WARNING, "pts has no value\n"); > >

Re: [FFmpeg-devel] [PATCH 5/5] avformat/movenc: add support for AV1 streams

2018-07-09 Thread James Almer
On 7/9/2018 7:23 PM, Baptiste Coudurier wrote: > Hi James, > > On Mon, Jul 9, 2018 at 11:26 AM, James Almer wrote: > > [...] > > >> @@ -5438,7 +5461,7 @@ int ff_mov_write_packet(AVFormatContext *s, >> AVPacket *pkt) >> av_log(s, AV_LOG_WARNING, "pts has no value\n"); >> pkt->

Re: [FFmpeg-devel] [PATCH 5/5] avformat/movenc: add support for AV1 streams

2018-07-09 Thread Baptiste Coudurier
Hi James, On Mon, Jul 9, 2018 at 11:26 AM, James Almer wrote: [...] > @@ -5438,7 +5461,7 @@ int ff_mov_write_packet(AVFormatContext *s, > AVPacket *pkt) > av_log(s, AV_LOG_WARNING, "pts has no value\n"); > pkt->pts = pkt->dts; > } > -if (pkt->dts != pkt->pts) > +

Re: [FFmpeg-devel] [PATCH 5/5] avformat/movenc: add support for AV1 streams

2018-07-09 Thread James Almer
On 7/9/2018 6:08 PM, Michael Niedermayer wrote: > On Mon, Jul 09, 2018 at 03:26:54PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> ff_av1_filter_obus() could eventually be replaced by an autoinserted >> filter_units bsf, assuming it doesn't slow down the muxing process >> too m

Re: [FFmpeg-devel] [PATCH 5/5] avformat/movenc: add support for AV1 streams

2018-07-09 Thread Michael Niedermayer
On Mon, Jul 09, 2018 at 03:26:54PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > ff_av1_filter_obus() could eventually be replaced by an autoinserted > filter_units bsf, assuming it doesn't slow down the muxing process > too much (CBS is fast reading packets, but not so much assem

[FFmpeg-devel] [PATCH 5/5] avformat/movenc: add support for AV1 streams

2018-07-09 Thread James Almer
Signed-off-by: James Almer --- ff_av1_filter_obus() could eventually be replaced by an autoinserted filter_units bsf, assuming it doesn't slow down the muxing process too much (CBS is fast reading packets, but not so much assembling and writing packets). ff_isom_write_av1c() however can't be repla