Re: [FFmpeg-devel] [PATCH 5/5] avcodec/g729dec: Use 64bit and clip in scalar product

2019-11-24 Thread Michael Niedermayer
On Wed, Nov 06, 2019 at 03:37:48PM +0100, Michael Niedermayer wrote: > On Wed, Nov 06, 2019 at 12:44:32AM +0100, Carl Eugen Hoyos wrote: > > Am Mi., 6. Nov. 2019 um 00:31 Uhr schrieb Michael Niedermayer > > : > > > > > > The G729 reference clips after each individual operation and keeps > > > track

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/g729dec: Use 64bit and clip in scalar product

2019-11-06 Thread Michael Niedermayer
On Wed, Nov 06, 2019 at 12:44:32AM +0100, Carl Eugen Hoyos wrote: > Am Mi., 6. Nov. 2019 um 00:31 Uhr schrieb Michael Niedermayer > : > > > > The G729 reference clips after each individual operation and keeps > > track if overflow occurred (in the fixed point implementation) > > I believe this is

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/g729dec: Use 64bit and clip in scalar product

2019-11-05 Thread Carl Eugen Hoyos
Am Mi., 6. Nov. 2019 um 00:31 Uhr schrieb Michael Niedermayer : > > The G729 reference clips after each individual operation and keeps > track if overflow occurred (in the fixed point implementation) I believe this is missing the word "decoder". Carl Eugen

[FFmpeg-devel] [PATCH 5/5] avcodec/g729dec: Use 64bit and clip in scalar product

2019-11-05 Thread Michael Niedermayer
The G729 reference clips after each individual operation and keeps track if overflow occurred (in the fixed point implementation), this here is simpler and faster but not 1:1 the same what the reference does. Non fuzzed samples which trigger any such overflow are welcome, so the need and impact o