Re: [FFmpeg-devel] [PATCH 4/5] x86: hevc_mc: fewer xmm regs used in epel h/v

2015-02-17 Thread Michael Niedermayer
On Tue, Feb 17, 2015 at 09:40:14AM +0100, Mickaël Raulet wrote: > Looks better to me. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 2 "100% positive feedback" - "All either got their money back or didnt complain"

Re: [FFmpeg-devel] [PATCH 4/5] x86: hevc_mc: fewer xmm regs used in epel h/v

2015-02-17 Thread Mickaël Raulet
Looks better to me. Mickaël Le mardi 17 février 2015, Christophe Gisquet a écrit : > 2015-02-17 8:28 GMT+01:00 Mickaël Raulet >: > > It seems to me that you are affecting 8 when it is avx2 instead of 11. > > Shouldn't it be the opposite? At least this what the commit message says. > > > Huh, b

Re: [FFmpeg-devel] [PATCH 4/5] x86: hevc_mc: fewer xmm regs used in epel h/v

2015-02-16 Thread Christophe Gisquet
2015-02-17 8:28 GMT+01:00 Mickaël Raulet : > It seems to me that you are affecting 8 when it is avx2 instead of 11. > Shouldn't it be the opposite? At least this what the commit message says. Huh, brainfart... And the fact that I can't easily test avx2 doesn't help. So here's a patch with the va

Re: [FFmpeg-devel] [PATCH 4/5] x86: hevc_mc: fewer xmm regs used in epel h/v

2015-02-16 Thread Mickaël Raulet
It seems to me that you are affecting 8 when it is avx2 instead of 11. Shouldn't it be the opposite? At least this what the commit message says. Mickaël Le mardi 17 février 2015, Christophe Gisquet a écrit : > Hi, > > here's an updated patch, which takes into account the fact avx2 > sometimes u

Re: [FFmpeg-devel] [PATCH 4/5] x86: hevc_mc: fewer xmm regs used in epel h/v

2015-02-16 Thread Christophe Gisquet
Hi, here's an updated patch, which takes into account the fact avx2 sometimes uses additional intermediate xmm regs. Maybe the fix is actually changing the avx2 code, but avx2 and x86_32 is a really weird combination. -- Christophe From 2955eea46501d096a47fbf2fb1824daa622f6031 Mon Sep 17 00:00:

[FFmpeg-devel] [PATCH 4/5] x86: hevc_mc: fewer xmm regs used in epel h/v

2015-02-07 Thread Christophe Gisquet
--- libavcodec/x86/hevc_mc.asm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/x86/hevc_mc.asm b/libavcodec/x86/hevc_mc.asm index 74e08d4..a127a4d 100644 --- a/libavcodec/x86/hevc_mc.asm +++ b/libavcodec/x86/hevc_mc.asm @@ -734,7 +734,7 @@ cglobal hevc_p