Re: [FFmpeg-devel] [PATCH 4/4] avformat/sapenc: fix leak in sap_write_header()

2025-06-24 Thread Michael Niedermayer
On Mon, Jun 23, 2025 at 08:54:24PM +0800, ld y wrote: > Michael Niedermayer writes: > > > this can be factored like: > > > > like > > +ret = 0; > > fail: > > +for (i = 0; i < s->nb_streams; i++) > > +if (contexts[i]) > > +av_free(contexts[i]->url); > > av_free

Re: [FFmpeg-devel] [PATCH 4/4] avformat/sapenc: fix leak in sap_write_header()

2025-06-23 Thread ld y
Michael Niedermayer writes: > this can be factored like: > > like > +ret = 0; > fail: > +for (i = 0; i < s->nb_streams; i++) > +if (contexts[i]) > +av_free(contexts[i]->url); > av_free(contexts); > + if (ret < 0) > sap_write_close(s); > Yeah this lo

Re: [FFmpeg-devel] [PATCH 4/4] avformat/sapenc: fix leak in sap_write_header()

2025-06-23 Thread Michael Niedermayer
On Tue, Jun 17, 2025 at 10:14:16PM +0800, Lidong Yan wrote: > In sap_write_header(), ff_format_set_url() assign new allocated new_url > to contexts[i]->url but forgot to free it later. Add two loops to free > contexts[i]->url before av_free(context). > > Signed-off-by: Lidong Yan <502024330...@sma

[FFmpeg-devel] [PATCH 4/4] avformat/sapenc: fix leak in sap_write_header()

2025-06-17 Thread Lidong Yan
In sap_write_header(), ff_format_set_url() assign new allocated new_url to contexts[i]->url but forgot to free it later. Add two loops to free contexts[i]->url before av_free(context). Signed-off-by: Lidong Yan <502024330...@smail.nju.edu.cn> --- libavformat/sapenc.c | 6 ++ 1 file changed, 6