Re: [FFmpeg-devel] [PATCH 4/4] avcodec/fitsdec: Check data_min/max

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 04:29:54PM +0200, Moritz Barsnick wrote: > On Thu, Jun 13, 2019 at 01:20:20 +0200, Michael Niedermayer wrote: > > +if (header->data_min == header->data_max) { > > Just a note: > Equality comparison of floats/doubles may trigger a warning. (Possibly > needs to be exp

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/fitsdec: Check data_min/max

2019-06-13 Thread Moritz Barsnick
On Thu, Jun 13, 2019 at 01:20:20 +0200, Michael Niedermayer wrote: > +if (header->data_min == header->data_max) { Just a note: Equality comparison of floats/doubles may trigger a warning. (Possibly needs to be explicitly enabled though, like with "-Wfloat-equal" on gcc.) Might be okay thou

[FFmpeg-devel] [PATCH 4/4] avcodec/fitsdec: Check data_min/max

2019-06-12 Thread Michael Niedermayer
Fixes: division by 0 Fixes: 15206/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FITS_fuzzer-5657260212092928 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/fitsdec.c | 10 ++ 1 fi