Re: [FFmpeg-devel] [PATCH 4/4] avcodec/dca: make reading past end of buffer safe

2016-03-03 Thread foo86
On Thu, Mar 03, 2016 at 12:56:42AM +0100, Hendrik Leppkes wrote: > On Thu, Mar 3, 2016 at 12:37 AM, Ronald S. Bultje wrote: > > Completely random comment, but isn't it easier to just enable the safe > > bitstream reader? > > > > This is actually enabled by default, so it probably should never hav

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/dca: make reading past end of buffer safe

2016-03-02 Thread Hendrik Leppkes
On Thu, Mar 3, 2016 at 12:37 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Mar 2, 2016 at 2:32 PM, foo86 wrote: > >> Limit the maximum length of unary part of Rice code by the number of >> available bits instead of using an arbitrary constant that happens to be >> just large enough to work. >> >>

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/dca: make reading past end of buffer safe

2016-03-02 Thread Ronald S. Bultje
Hi, On Wed, Mar 2, 2016 at 2:32 PM, foo86 wrote: > Limit the maximum length of unary part of Rice code by the number of > available bits instead of using an arbitrary constant that happens to be > just large enough to work. > > This effectively limits amount of data that can be overread per segm

[FFmpeg-devel] [PATCH 4/4] avcodec/dca: make reading past end of buffer safe

2016-03-02 Thread foo86
Limit the maximum length of unary part of Rice code by the number of available bits instead of using an arbitrary constant that happens to be just large enough to work. This effectively limits amount of data that can be overread per segment by maximum length of binary code per sample multiplied by