Re: [FFmpeg-devel] [PATCH 36/39] avcodec/speedhqenc: Call correct function

2020-12-10 Thread Andreas Rheinhardt
Paul B Mahol: > OK, > > I guess encoding still works. > Yes, it does. In fact, you need to enable either trellis or quantizer_noise_shaping for it to make a difference. A quick test with trellis on showed strange artifacts without this patch that are eliminated by this patch; furthermore, the ou

Re: [FFmpeg-devel] [PATCH 36/39] avcodec/speedhqenc: Call correct function

2020-12-10 Thread Paul B Mahol
OK, I guess encoding still works. On Thu, Dec 10, 2020 at 12:25 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Up until now, the SpeedHQ encoder called a wrong function for init: > void ff_init_uni_ac_vlc(const uint8_t huff_size_ac[256], > uint8_t *uni_ac_

[FFmpeg-devel] [PATCH 36/39] avcodec/speedhqenc: Call correct function

2020-12-10 Thread Andreas Rheinhardt
Up until now, the SpeedHQ encoder called a wrong function for init: void ff_init_uni_ac_vlc(const uint8_t huff_size_ac[256], uint8_t *uni_ac_vlc_len); Yet the first argument actually used is of type RLTable; the size of said struct is less than 256 if the size of a pointer i