Re: [FFmpeg-devel] [PATCH 3/6] put_bits: make avpriv_align_put_bits() inline

2020-10-27 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-10-26 15:21:26) > Unnecessary: The code below also works for LE writers, now that the LE > version of put_bits() is called. Right, changed locally. > > > diff --git a/libavcodec/version.h b/libavcodec/version.h > > index 02ffa95749..78c4dd64ee 100644 > > --- a/li

Re: [FFmpeg-devel] [PATCH 3/6] put_bits: make avpriv_align_put_bits() inline

2020-10-26 Thread Andreas Rheinhardt
Anton Khirnov: > This function is so extremely simple that it is preferable to make it > inline rather than deal with all the complications arising from it being > an exported symbol. > > Keep avpriv_align_put_bits() around until the next major bump to > preserve ABI compatibility. > --- > libavc

[FFmpeg-devel] [PATCH 3/6] put_bits: make avpriv_align_put_bits() inline

2020-10-26 Thread Anton Khirnov
This function is so extremely simple that it is preferable to make it inline rather than deal with all the complications arising from it being an exported symbol. Keep avpriv_align_put_bits() around until the next major bump to preserve ABI compatibility. --- libavcodec/aacenc.c | 4 ++-- li