Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

2020-07-15 Thread lance . lmwang
On Wed, Jul 15, 2020 at 06:02:43PM +0100, Kieran Kunhya wrote: > On Wed, 15 Jul 2020 at 16:52, wrote: > > > On Wed, Jul 15, 2020 at 04:16:38PM +0100, Kieran Kunhya wrote: > > > If you look a few lines above, we already set the timecode side data. > > > > > > > are you saying av_frame_new_side_dat

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

2020-07-15 Thread lance . lmwang
On Wed, Jul 15, 2020 at 07:01:33PM +0200, Hendrik Leppkes wrote: > On Wed, Jul 15, 2020 at 5:52 PM wrote: > > > > On Wed, Jul 15, 2020 at 04:16:38PM +0100, Kieran Kunhya wrote: > > > If you look a few lines above, we already set the timecode side data. > > > > > > > are you saying av_frame_new_sid

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

2020-07-15 Thread Hendrik Leppkes
On Wed, Jul 15, 2020 at 5:52 PM wrote: > > On Wed, Jul 15, 2020 at 04:16:38PM +0100, Kieran Kunhya wrote: > > If you look a few lines above, we already set the timecode side data. > > > > are you saying av_frame_new_side_data() above? that's total different, in > fact, > I'm try to use the same

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

2020-07-15 Thread Kieran Kunhya
On Wed, 15 Jul 2020 at 16:52, wrote: > On Wed, Jul 15, 2020 at 04:16:38PM +0100, Kieran Kunhya wrote: > > If you look a few lines above, we already set the timecode side data. > > > > are you saying av_frame_new_side_data() above? that's total different, in > fact, > I'm try to use the same way

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

2020-07-15 Thread lance . lmwang
On Wed, Jul 15, 2020 at 04:16:38PM +0100, Kieran Kunhya wrote: > If you look a few lines above, we already set the timecode side data. > are you saying av_frame_new_side_data() above? that's total different, in fact, I'm try to use the same way with ff_add_cpb_side_data(), it'll put TC in the c

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

2020-07-15 Thread Kieran Kunhya
If you look a few lines above, we already set the timecode side data. Sent from my mobile device On Wed, 15 Jul 2020, 14:44 , wrote: > On Wed, Jul 15, 2020 at 09:16:16AM +0100, Kieran Kunhya wrote: > > On Wed, 15 Jul 2020 at 02:19, wrote: > > > > > On Wed, Jul 15, 2020 at 12:54:35AM +0100, Kie

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

2020-07-15 Thread lance . lmwang
On Wed, Jul 15, 2020 at 09:16:16AM +0100, Kieran Kunhya wrote: > On Wed, 15 Jul 2020 at 02:19, wrote: > > > On Wed, Jul 15, 2020 at 12:54:35AM +0100, Kieran Kunhya wrote: > > > On Wed, 15 Jul 2020 at 00:36, wrote: > > > > > > > From: Limin Wang > > > > > > > > Signed-off-by: Limin Wang > > > >

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

2020-07-15 Thread Kieran Kunhya
On Wed, 15 Jul 2020 at 02:19, wrote: > On Wed, Jul 15, 2020 at 12:54:35AM +0100, Kieran Kunhya wrote: > > On Wed, 15 Jul 2020 at 00:36, wrote: > > > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang > > > --- > > > libavcodec/h264_slice.c | 10 ++ > > > 1 file changed, 10 ins

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

2020-07-14 Thread lance . lmwang
On Wed, Jul 15, 2020 at 12:54:35AM +0100, Kieran Kunhya wrote: > On Wed, 15 Jul 2020 at 00:36, wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/h264_slice.c | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/libavcodec/h264_slice.c

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

2020-07-14 Thread Kieran Kunhya
On Wed, 15 Jul 2020 at 00:36, wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/h264_slice.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c > index c7b2764..db720de 100644 > --- a/libavcodec/h264_s

[FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

2020-07-14 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264_slice.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index c7b2764..db720de 100644 --- a/libavcodec/h264_slice.c +++ b/libavcodec/h264_slice.c @@ -1307,6 +1307,7 @