Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-11-07 Thread Pierre-Anthony Lemieux
The comments have been addressed in v3 of the patch. On Sun, Oct 31, 2021 at 1:22 PM Pierre-Anthony Lemieux wrote: > > On Sun, Oct 31, 2021 at 11:45 AM James Almer wrote: > > > > On 10/31/2021 3:34 PM, Pierre-Anthony Lemieux wrote: > > >>> The functions are not static and are defined in imf_in

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-31 Thread Pierre-Anthony Lemieux
On Sun, Oct 31, 2021 at 11:45 AM James Almer wrote: > > On 10/31/2021 3:34 PM, Pierre-Anthony Lemieux wrote: > >>> The functions are not static and are defined in imf_internal.h. They > >>> are used in both libavformat/imfdec.c and the tests at > >>> libavformat/tests/imf.c. Ok? > >> > >> If they

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-31 Thread James Almer
On 10/31/2021 3:34 PM, Pierre-Anthony Lemieux wrote: The functions are not static and are defined in imf_internal.h. They are used in both libavformat/imfdec.c and the tests at libavformat/tests/imf.c. Ok? If they are used in libavformat only it should be static. AFAIK static functions are onl

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-31 Thread Paul B Mahol
On Sun, Oct 31, 2021 at 7:34 PM Pierre-Anthony Lemieux wrote: > On Thu, Oct 28, 2021 at 12:58 AM Paul B Mahol wrote: > > > > > > > > On Thu, Oct 28, 2021 at 6:32 AM Pierre-Anthony Lemieux > wrote: > >> > >> On Wed, Oct 27, 2021 at 12:54 AM Paul B Mahol wrote: > >> > > >> > > >> > > >> > On Fri

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-31 Thread Pierre-Anthony Lemieux
On Thu, Oct 28, 2021 at 12:58 AM Paul B Mahol wrote: > > > > On Thu, Oct 28, 2021 at 6:32 AM Pierre-Anthony Lemieux > wrote: >> >> On Wed, Oct 27, 2021 at 12:54 AM Paul B Mahol wrote: >> > >> > >> > >> > On Fri, Oct 8, 2021 at 1:42 AM wrote: >> >> >> >> From: Pierre-Anthony Lemieux >> >> >> >

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-28 Thread Paul B Mahol
On Thu, Oct 28, 2021 at 6:32 AM Pierre-Anthony Lemieux wrote: > On Wed, Oct 27, 2021 at 12:54 AM Paul B Mahol wrote: > > > > > > > > On Fri, Oct 8, 2021 at 1:42 AM wrote: > >> > >> From: Pierre-Anthony Lemieux > >> > >> Signed-off-by: Pierre-Anthony Lemieux > >> --- > >> > >> Notes: > >>

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-27 Thread Pierre-Anthony Lemieux
On Wed, Oct 27, 2021 at 12:54 AM Paul B Mahol wrote: > > > > On Fri, Oct 8, 2021 at 1:42 AM wrote: >> >> From: Pierre-Anthony Lemieux >> >> Signed-off-by: Pierre-Anthony Lemieux >> --- >> >> Notes: >> Implements the IMF demuxer. >> >> libavformat/imfdec.c | 660

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-27 Thread Paul B Mahol
On Fri, Oct 8, 2021 at 1:42 AM wrote: > From: Pierre-Anthony Lemieux > > Signed-off-by: Pierre-Anthony Lemieux > --- > > Notes: > Implements the IMF demuxer. > > libavformat/imfdec.c | 660 +++ > 1 file changed, 660 insertions(+) > create mode 10064

[FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-20 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Implements the IMF demuxer. libavformat/imfdec.c | 660 +++ 1 file changed, 660 insertions(+) create mode 100644 libavformat/imfdec.c diff --git a/libavformat/imfdec.c b

[FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-07 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Implements the IMF demuxer. libavformat/imfdec.c | 660 +++ 1 file changed, 660 insertions(+) create mode 100644 libavformat/imfdec.c diff --git a/libavformat/imfdec.c b

[FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-09-29 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Implements the IMF demuxer. libavformat/imfdec.c | 646 +++ 1 file changed, 646 insertions(+) create mode 100644 libavformat/imfdec.c diff --git a/libavformat/imfdec.c b