On 08/02/2016 05:26 PM, James Almer wrote:
On 8/2/2016 12:14 PM, Nicolas George wrote:
+AVBSFList *av_bsf_list_alloc(void);
This is personal, but for new APIs, I like "int foo_alloc(Foo **rfoo)"
better than "Foo *foo_alloc(void)": that way, the caller can forward the
error code instead of gue
Hello Nicolas,
On 08/02/2016 05:14 PM, Nicolas George wrote:
+AVBSFList *av_bsf_list_alloc(void);
This is personal, but for new APIs, I like "int foo_alloc(Foo **rfoo)"
better than "Foo *foo_alloc(void)": that way, the caller can forward the
error code instead of guessing it is ENOMEM.
I le
Sorry, I seem to have lost the original mail, and as Gmane is dead I had to
review using Nicolas's mail.
On Tue, Aug 2, 2016 at 8:14 AM Nicolas George wrote:
> Le primidi 11 thermidor, an CCXXIV, sebechlebsky...@gmail.com a écrit :
> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> >
On 8/2/2016 12:14 PM, Nicolas George wrote:
>> +AVBSFList *av_bsf_list_alloc(void);
> This is personal, but for new APIs, I like "int foo_alloc(Foo **rfoo)"
> better than "Foo *foo_alloc(void)": that way, the caller can forward the
> error code instead of guessing it is ENOMEM.
There is no other e
Le primidi 11 thermidor, an CCXXIV, sebechlebsky...@gmail.com a écrit :
> From: Jan Sebechlebsky
>
> ---
> libavcodec/avcodec.h | 74 ++
> libavcodec/bsf.c | 284
> +++
> 2 files changed, 358 insertions(+)
Looks rather nice. Comm
From: Jan Sebechlebsky
---
libavcodec/avcodec.h | 74 ++
libavcodec/bsf.c | 284 +++
2 files changed, 358 insertions(+)
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 36f7935..39106ee 100644
--- a/libavcodec/avcode
