Re: [FFmpeg-devel] [PATCH 3/4 v2] avcodec/libx265: export encoded frame stats

2019-12-30 Thread Derek Buitenhuis
On 30/12/2019 23:53, James Almer wrote: >> Does multiplying by FF_QP2LAMBDA even make sense here? That contsant >> is for H.263's QP scale, not HEVC's. > > Pretty much every call to ff_side_data_set_encoder_stats() in lavc does > it, including libx264, so i figure it's expected. It looks like it

Re: [FFmpeg-devel] [PATCH 3/4 v2] avcodec/libx265: export encoded frame stats

2019-12-30 Thread James Almer
On 12/30/2019 8:06 PM, Derek Buitenhuis wrote: > On 30/12/2019 19:20, James Almer wrote: >> +ff_side_data_set_encoder_stats(pkt, x265pic_out.frameData.qp * >> FF_QP2LAMBDA, NULL, 0, pict_type); > > Does multiplying by FF_QP2LAMBDA even make sense here? That contsant > is for H.263's QP scale,

Re: [FFmpeg-devel] [PATCH 3/4 v2] avcodec/libx265: export encoded frame stats

2019-12-30 Thread Derek Buitenhuis
On 30/12/2019 19:20, James Almer wrote: > +ff_side_data_set_encoder_stats(pkt, x265pic_out.frameData.qp * > FF_QP2LAMBDA, NULL, 0, pict_type); Does multiplying by FF_QP2LAMBDA even make sense here? That contsant is for H.263's QP scale, not HEVC's. - Derek ___

[FFmpeg-devel] [PATCH 3/4 v2] avcodec/libx265: export encoded frame stats

2019-12-30 Thread James Almer
Signed-off-by: James Almer --- No changes. libavcodec/libx265.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 9646e208f4..a97bf19e91 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -484,6 +4