Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-04 Thread Henrik Gramner
On Mon, Aug 3, 2015 at 1:37 AM, Ronald S. Bultje wrote: > Does silencing these warnings still work after this patch? > > If so: ok. > > Ronald Applied. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-03 Thread Henrik Gramner
On Mon, Aug 3, 2015 at 1:37 AM, Ronald S. Bultje wrote: > Does silencing these warnings still work after this patch? Yes, undefining __SECT__ is no longer needed after this patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/m

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-03 Thread Henrik Gramner
On Mon, Aug 3, 2015 at 9:02 AM, Dave Yeo wrote: > Here, if the 32 is left as the alignment, the build dies. That's why I removed the 32. It seems to run fine on Haswell (which has AVX2) without it, so I don't know the reason for why it was added in the first place. ___

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-03 Thread Dave Yeo
On 08/02/15 11:04 PM, Clément Bœsch wrote: On Sun, Aug 02, 2015 at 10:40:02PM +0200, Henrik Gramner wrote: The .text section is already 16-byte aligned by default on all supported platforms so `SECTION_TEXT` isn't any different from `SECTION .text`. naive question, what about the few SECTION_T

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-02 Thread Henrik Gramner
On Mon, Aug 3, 2015 at 8:04 AM, Clément Bœsch wrote: > naive question, what about the few SECTION_TEXT 32? I don't know why 32-byte alignment was used for the text section in the first place. Functions are only 16-byte aligned anyway. ___ ffmpeg-devel ma

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-02 Thread Clément Bœsch
On Sun, Aug 02, 2015 at 10:40:02PM +0200, Henrik Gramner wrote: > The .text section is already 16-byte aligned by default on all supported > platforms so `SECTION_TEXT` isn't any different from `SECTION .text`. naive question, what about the few SECTION_TEXT 32? [...] -- Clément B. pgpiCW7CJ2

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-02 Thread Ronald S. Bultje
Hi, On Sun, Aug 2, 2015 at 4:40 PM, Henrik Gramner wrote: > The .text section is already 16-byte aligned by default on all supported > platforms so `SECTION_TEXT` isn't any different from `SECTION .text`.-; > Overrides the default .text section. > -; Silences warnings when defining structures. >

[FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-02 Thread Henrik Gramner
The .text section is already 16-byte aligned by default on all supported platforms so `SECTION_TEXT` isn't any different from `SECTION .text`. --- libavcodec/x86/aacpsdsp.asm | 2 +- libavcodec/x86/audiodsp.asm | 2 +- libavcodec/x86/blockdsp.asm | 2 +- libavcodec/x8