Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

2015-12-01 Thread Ganesh Ajjanagadde
On Mon, Nov 16, 2015 at 1:58 PM, Ganesh Ajjanagadde wrote: > On Mon, Nov 16, 2015 at 1:20 PM, Hendrik Leppkes wrote: >> On Mon, Nov 16, 2015 at 6:24 PM, Ganesh Ajjanagadde wrote: >>> On Mon, Nov 16, 2015 at 9:48 AM, Daniel Serpell wrote: Hi!, El Fri, Nov 13, 2015 at 11:42:30AM -0

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

2015-11-16 Thread Ganesh Ajjanagadde
On Mon, Nov 16, 2015 at 1:20 PM, Hendrik Leppkes wrote: > On Mon, Nov 16, 2015 at 6:24 PM, Ganesh Ajjanagadde wrote: >> On Mon, Nov 16, 2015 at 9:48 AM, Daniel Serpell wrote: >>> Hi!, >>> >>> El Fri, Nov 13, 2015 at 11:42:30AM -0500, Ganesh Ajjanagadde escribio: Whoever wrote this stuff had

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

2015-11-16 Thread Hendrik Leppkes
On Mon, Nov 16, 2015 at 6:24 PM, Ganesh Ajjanagadde wrote: > On Mon, Nov 16, 2015 at 9:48 AM, Daniel Serpell wrote: >> Hi!, >> >> El Fri, Nov 13, 2015 at 11:42:30AM -0500, Ganesh Ajjanagadde escribio: >>> Whoever wrote this stuff had a pretty bad libm - digits differ pretty >>> quickly. >> >> The

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

2015-11-16 Thread Ganesh Ajjanagadde
On Mon, Nov 16, 2015 at 9:48 AM, Daniel Serpell wrote: > Hi!, > > El Fri, Nov 13, 2015 at 11:42:30AM -0500, Ganesh Ajjanagadde escribio: >> Whoever wrote this stuff had a pretty bad libm - digits differ pretty >> quickly. > > They where correctly rounded to 24bit precision. I don't know if that >

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

2015-11-16 Thread Daniel Serpell
Hi!, El Fri, Nov 13, 2015 at 11:42:30AM -0500, Ganesh Ajjanagadde escribio: > Whoever wrote this stuff had a pretty bad libm - digits differ pretty > quickly. They where correctly rounded to 24bit precision. I don't know if that was intentional, so I can't comment on the correctness of the patch.

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

2015-11-13 Thread Ganesh Ajjanagadde
On Fri, Nov 13, 2015 at 2:58 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Nov 13, 2015 at 11:42 AM, Ganesh Ajjanagadde > wrote: >> >> Whoever wrote this stuff had a pretty bad libm - digits differ pretty >> quickly. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavcodec/ppc/fdctdsp.c | 1

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

2015-11-13 Thread Ronald S. Bultje
Hi, On Fri, Nov 13, 2015 at 11:42 AM, Ganesh Ajjanagadde wrote: > Whoever wrote this stuff had a pretty bad libm - digits differ pretty > quickly. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/ppc/fdctdsp.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > d

[FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

2015-11-13 Thread Ganesh Ajjanagadde
Whoever wrote this stuff had a pretty bad libm - digits differ pretty quickly. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/ppc/fdctdsp.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/ppc/fdctdsp.c b/libavcodec/ppc/fdctdsp.c index 924d12c..9286