Re: [FFmpeg-devel] [PATCH 3/3] nutdec: fix memleaks on error in nut_read_header

2015-04-28 Thread Andreas Cadhalpun
On 28.04.2015 22:55, Michael Niedermayer wrote: > On Tue, Apr 28, 2015 at 08:58:21PM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun > [...] >> @@ -806,7 +811,10 @@ static int nut_read_header(AVFormatContext *s) >> >> ff_metadata_conv_ctx(s, NULL, ff_nut_metadata_conv);

Re: [FFmpeg-devel] [PATCH 3/3] nutdec: fix memleaks on error in nut_read_header

2015-04-28 Thread Michael Niedermayer
On Tue, Apr 28, 2015 at 08:58:21PM +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun [...] > @@ -806,7 +811,10 @@ static int nut_read_header(AVFormatContext *s) > > ff_metadata_conv_ctx(s, NULL, ff_nut_metadata_conv); > > -return 0; > +end: > +if (ret < 0) > +

Re: [FFmpeg-devel] [PATCH 3/3] nutdec: fix memleaks on error in nut_read_header

2015-04-28 Thread Michael Niedermayer
On Tue, Apr 28, 2015 at 08:58:21PM +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/nutdec.c | 18 +- > 1 file changed, 13 insertions(+), 5 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC78

[FFmpeg-devel] [PATCH 3/3] nutdec: fix memleaks on error in nut_read_header

2015-04-28 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavformat/nutdec.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 2049f70..191b285 100644 --- a/libavformat/nutdec.c +++ b/libavformat/nutdec.c @@ -745,12 +745,14 @@ f