Re: [FFmpeg-devel] [PATCH 3/3] libswresample: move condition to start of loop.

2014-09-06 Thread Michael Niedermayer
On Sat, Sep 06, 2014 at 09:25:51PM +0200, Reimar Döffinger wrote: > This avoids several issue like calculating sum/maxcoef > incorrectly due to adding up matrix entries that will > be overwritten, as well as out-of-range writes to > s->matrix if the maximum allowed number of channels is used. > >

[FFmpeg-devel] [PATCH 3/3] libswresample: move condition to start of loop.

2014-09-06 Thread Reimar Döffinger
This avoids several issue like calculating sum/maxcoef incorrectly due to adding up matrix entries that will be overwritten, as well as out-of-range writes to s->matrix if the maximum allowed number of channels is used. Signed-off-by: Reimar Döffinger --- libswresample/rematrix.c | 10 ++