Re: [FFmpeg-devel] [PATCH 3/3] lavc/cbrt_tablegen: unroll table generation loop

2015-12-31 Thread Ganesh Ajjanagadde
On Thu, Dec 31, 2015 at 5:08 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 31, 2015 at 6:53 PM, Ganesh Ajjanagadde > wrote: >> >> BTW, it would also help me if you or an AAC maintainer can come up >> with a number below which dynamic initialization can always be done. > > > I think the answer

Re: [FFmpeg-devel] [PATCH 3/3] lavc/cbrt_tablegen: unroll table generation loop

2015-12-31 Thread Ronald S. Bultje
Hi, On Thu, Dec 31, 2015 at 6:53 PM, Ganesh Ajjanagadde wrote: > BTW, it would also help me if you or an AAC maintainer can come up > with a number below which dynamic initialization can always be done. I think the answer is "never", since 0 is always faster than any number. But that's not an

Re: [FFmpeg-devel] [PATCH 3/3] lavc/cbrt_tablegen: unroll table generation loop

2015-12-31 Thread Ganesh Ajjanagadde
On Thu, Dec 31, 2015 at 3:53 PM, Ganesh Ajjanagadde wrote: > On Thu, Dec 31, 2015 at 8:46 AM, Ronald S. Bultje wrote: >> Hi, >> >> On Thu, Dec 31, 2015 at 11:39 AM, Ganesh Ajjanagadde >> wrote: >>> >>> This patch does not seem to have measurable impact, at least on x86-64, >>> though >>> there c

Re: [FFmpeg-devel] [PATCH 3/3] lavc/cbrt_tablegen: unroll table generation loop

2015-12-31 Thread Ganesh Ajjanagadde
On Thu, Dec 31, 2015 at 8:46 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 31, 2015 at 11:39 AM, Ganesh Ajjanagadde > wrote: >> >> This patch does not seem to have measurable impact, at least on x86-64, >> though >> there could be benefits for less than stellar branch predictors. > > [..] >>

Re: [FFmpeg-devel] [PATCH 3/3] lavc/cbrt_tablegen: unroll table generation loop

2015-12-31 Thread Ganesh Ajjanagadde
On Thu, Dec 31, 2015 at 8:46 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 31, 2015 at 11:39 AM, Ganesh Ajjanagadde > wrote: >> >> This patch does not seem to have measurable impact, at least on x86-64, >> though >> there could be benefits for less than stellar branch predictors. > > [..] >>

Re: [FFmpeg-devel] [PATCH 3/3] lavc/cbrt_tablegen: unroll table generation loop

2015-12-31 Thread Ronald S. Bultje
Hi, On Thu, Dec 31, 2015 at 11:39 AM, Ganesh Ajjanagadde wrote: > This patch does not seem to have measurable impact, at least on x86-64, > though > there could be benefits for less than stellar branch predictors. > [..] > -for (i = 0; i < 1<<13; i++) { > -if (!(i & 7)) > -

[FFmpeg-devel] [PATCH 3/3] lavc/cbrt_tablegen: unroll table generation loop

2015-12-31 Thread Ganesh Ajjanagadde
This patch does not seem to have measurable impact, at least on x86-64, though there could be benefits for less than stellar branch predictors. As such, the least useful of the series. Tested with FATE. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/cbrt_tablegen.h | 14 +- 1 fil