Re: [FFmpeg-devel] [PATCH 3/3] h264/pic_timing: support multiple timecodes

2018-10-12 Thread Carl Eugen Hoyos
2018-10-11 15:04 GMT+02:00, Joshua de Kock : > On 9 October 2018 at 21:03, Carl Eugen Hoyos wrote: >> 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : >>> From: Josh de Kock >> >>> [...] >> >> If the first patch gets committed as-is, please split this one >> in a functional and a cosmetic patc

Re: [FFmpeg-devel] [PATCH 3/3] h264/pic_timing: support multiple timecodes

2018-10-11 Thread Joshua de Kock
On 9 October 2018 at 21:03, Carl Eugen Hoyos wrote: > 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : >> From: Josh de Kock > >> [...] > > If the first patch gets committed as-is, please split this one > in a functional and a cosmetic patch, above is unreviewable. > > Thank you, Carl Eugen I

Re: [FFmpeg-devel] [PATCH 3/3] h264/pic_timing: support multiple timecodes

2018-10-09 Thread Carl Eugen Hoyos
2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : > From: Josh de Kock > -/* For SMPTE 12-M timecodes, frame count is a special case if > 30 > FPS. > - See SMPTE ST 12-1:2014 Sec 12.1 for more info. */ > -if (av_cmp_q(h->avctx->framerate, (AVRational) {30, 1}) == 1) {

[FFmpeg-devel] [PATCH 3/3] h264/pic_timing: support multiple timecodes

2018-10-09 Thread joshdk
From: Josh de Kock --- libavcodec/h264_sei.c | 21 -- libavcodec/h264_sei.h | 28 +-- libavcodec/h264_slice.c | 59 ++- libavfilter/vf_showinfo.c | 10 +++ 4 files changed, 75 insertions(+), 43 deletions(-) diff --git