Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

2019-09-17 Thread Michael Niedermayer
On Sun, Sep 15, 2019 at 04:35:30PM -0300, James Almer wrote: > On 9/15/2019 4:34 PM, Michael Niedermayer wrote: > > On Sat, Aug 31, 2019 at 10:36:32AM -0300, James Almer wrote: > >> On 8/31/2019 5:47 AM, Michael Niedermayer wrote: > >>> On Fri, Aug 30, 2019 at 08:57:29PM -0300, James Almer wrote: >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

2019-09-15 Thread James Almer
On 9/15/2019 4:34 PM, Michael Niedermayer wrote: > On Sat, Aug 31, 2019 at 10:36:32AM -0300, James Almer wrote: >> On 8/31/2019 5:47 AM, Michael Niedermayer wrote: >>> On Fri, Aug 30, 2019 at 08:57:29PM -0300, James Almer wrote: On 8/30/2019 8:25 PM, Michael Niedermayer wrote: > Fixes: Tim

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

2019-09-15 Thread Michael Niedermayer
On Sat, Aug 31, 2019 at 10:36:32AM -0300, James Almer wrote: > On 8/31/2019 5:47 AM, Michael Niedermayer wrote: > > On Fri, Aug 30, 2019 at 08:57:29PM -0300, James Almer wrote: > >> On 8/30/2019 8:25 PM, Michael Niedermayer wrote: > >>> Fixes: Timeout (195sec -> 2ms) > >>> Fixes: > >>> 16735/clust

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

2019-08-31 Thread Nicolas George
James Almer (12019-08-31): > There's Marton's "avformat/utils: return pending IO error on EOF in > av_read_frame()" patch to check in generic code if avio_feof() != 0 is > an actual EOF or an IO error, so if you make this code here simply break > the loop, same as it's done in mov_read_default(), t

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

2019-08-31 Thread James Almer
On 8/31/2019 5:47 AM, Michael Niedermayer wrote: > On Fri, Aug 30, 2019 at 08:57:29PM -0300, James Almer wrote: >> On 8/30/2019 8:25 PM, Michael Niedermayer wrote: >>> Fixes: Timeout (195sec -> 2ms) >>> Fixes: >>> 16735/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5090676403863552 >>> >>>

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

2019-08-31 Thread Michael Niedermayer
On Fri, Aug 30, 2019 at 08:57:29PM -0300, James Almer wrote: > On 8/30/2019 8:25 PM, Michael Niedermayer wrote: > > Fixes: Timeout (195sec -> 2ms) > > Fixes: > > 16735/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5090676403863552 > > > > Found-by: continuous fuzzing process > > https://g

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

2019-08-30 Thread James Almer
On 8/30/2019 8:25 PM, Michael Niedermayer wrote: > Fixes: Timeout (195sec -> 2ms) > Fixes: > 16735/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5090676403863552 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Mich

[FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

2019-08-30 Thread Michael Niedermayer
Fixes: Timeout (195sec -> 2ms) Fixes: 16735/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5090676403863552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 5 - 1 file chang