Re: [FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-10 Thread Marton Balint
On Sat, 10 Aug 2019, Nicolas George wrote: Marton Balint (12019-08-08): Current 4k limit is definitely causing errors, the users are not aware of it, because it is not intuitive. I don't see why increasing the limit to 2 GB which is something that we will hardly ever hit is worse than curren

Re: [FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-10 Thread Nicolas George
Marton Balint (12019-08-08): > Current 4k limit is definitely causing errors, the users are not aware of > it, because it is not intuitive. > > I don't see why increasing the limit to 2 GB which is something that we will > hardly ever hit is worse than current status which causes actual issues. >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-08 Thread Paul B Mahol
On Thu, Aug 8, 2019 at 10:43 AM Nicolas George wrote: > Marton Balint (12019-08-07): > > The function returns an int so it can't signal writing longer strings > that > > that. > > Yet, replacing an arbitrary limit by another arbitrary limit, however > high, seems very wrong. > > But function retu

Re: [FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-08 Thread Marton Balint
On Thu, 8 Aug 2019, Nicolas George wrote: Marton Balint (12019-08-07): The function returns an int so it can't signal writing longer strings that that. Yet, replacing an arbitrary limit by another arbitrary limit, however high, seems very wrong. Current 4k limit is definitely causing erro

Re: [FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-08 Thread Nicolas George
Marton Balint (12019-08-07): > The function returns an int so it can't signal writing longer strings that > that. Yet, replacing an arbitrary limit by another arbitrary limit, however high, seems very wrong. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-06 Thread Marton Balint
On Tue, 6 Aug 2019, Nicolas George wrote: Marton Balint (12019-08-05): We do this by switching to AVBPrint. Signed-off-by: Marton Balint --- doc/APIchanges| 3 +++ libavformat/avio.h| 5 - libavformat/aviobuf.c | 15 ++- libavformat/version.h | 2 +- 4 files

Re: [FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-06 Thread Nicolas George
Marton Balint (12019-08-05): > We do this by switching to AVBPrint. > > Signed-off-by: Marton Balint > --- > doc/APIchanges| 3 +++ > libavformat/avio.h| 5 - > libavformat/aviobuf.c | 15 ++- > libavformat/version.h | 2 +- > 4 files changed, 18 insertions(+), 7 d

[FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-05 Thread Marton Balint
We do this by switching to AVBPrint. Signed-off-by: Marton Balint --- doc/APIchanges| 3 +++ libavformat/avio.h| 5 - libavformat/aviobuf.c | 15 ++- libavformat/version.h | 2 +- 4 files changed, 18 insertions(+), 7 deletions(-) diff --git a/doc/APIchanges b/doc/