Re: [FFmpeg-devel] [PATCH 3/3] avcodec/ac3dsp: make len a size_t in float_to_fixed24

2023-11-26 Thread Anton Khirnov
Quoting James Almer (2023-11-24 22:03:29) > On 11/24/2023 6:01 PM, Michael Niedermayer wrote: > > On Wed, Nov 22, 2023 at 04:49:13PM -0300, James Almer wrote: > >> Should simplify asm implementations, and prevent UB on at least win64. > >> > >> Signed-off-by: James Almer > >> --- > >> libavcodec

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/ac3dsp: make len a size_t in float_to_fixed24

2023-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2023 at 06:03:29PM -0300, James Almer wrote: > On 11/24/2023 6:01 PM, Michael Niedermayer wrote: > > On Wed, Nov 22, 2023 at 04:49:13PM -0300, James Almer wrote: > > > Should simplify asm implementations, and prevent UB on at least win64. > > > > > > Signed-off-by: James Almer > >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/ac3dsp: make len a size_t in float_to_fixed24

2023-11-24 Thread James Almer
On 11/24/2023 6:01 PM, Michael Niedermayer wrote: On Wed, Nov 22, 2023 at 04:49:13PM -0300, James Almer wrote: Should simplify asm implementations, and prevent UB on at least win64. Signed-off-by: James Almer --- libavcodec/ac3dsp.c | 2 +- libavcodec/ac3dsp.h | 2

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/ac3dsp: make len a size_t in float_to_fixed24

2023-11-24 Thread Michael Niedermayer
On Wed, Nov 22, 2023 at 04:49:13PM -0300, James Almer wrote: > Should simplify asm implementations, and prevent UB on at least win64. > > Signed-off-by: James Almer > --- > libavcodec/ac3dsp.c | 2 +- > libavcodec/ac3dsp.h | 2 +- > libavcodec/arm/ac3dsp_init_arm.c | 2

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/ac3dsp: make len a size_t in float_to_fixed24

2023-11-22 Thread Rémi Denis-Courmont
Le keskiviikkona 22. marraskuuta 2023, 21.49.13 EET James Almer a écrit : > Should simplify asm implementations, and prevent UB on at least win64. > > Signed-off-by: James Almer This one looks good to me, but I am utterly incompetent for the previous two. -- 雷米‧德尼-库尔蒙 http://www.remlab.net/

[FFmpeg-devel] [PATCH 3/3] avcodec/ac3dsp: make len a size_t in float_to_fixed24

2023-11-22 Thread James Almer
Should simplify asm implementations, and prevent UB on at least win64. Signed-off-by: James Almer --- libavcodec/ac3dsp.c | 2 +- libavcodec/ac3dsp.h | 2 +- libavcodec/arm/ac3dsp_init_arm.c | 2 +- libavcodec/mips/ac3dsp_mips.c| 2 +- libavcodec/x86/ac3dsp_init.c