Re: [FFmpeg-devel] [PATCH 25/35] avutil/opt: add av_opt_to_string

2021-06-11 Thread Diederick C. Niehorster
On Thu, Jun 10, 2021 at 12:08 PM Diederick C. Niehorster wrote: > > On Thu, Jun 10, 2021 at 11:39 AM Diederick C. Niehorster > wrote: > > So in av_opt_get(), I'd do something like this: > > AVBPrint buf; > > av_bprint_init(&buf, 0, AV_BPRINT_SIZE_AUTOMATIC); > > // 1. call internal print function

Re: [FFmpeg-devel] [PATCH 25/35] avutil/opt: add av_opt_to_string

2021-06-10 Thread Diederick C. Niehorster
On Thu, Jun 10, 2021 at 11:39 AM Diederick C. Niehorster wrote: > So in av_opt_get(), I'd do something like this: > AVBPrint buf; > av_bprint_init(&buf, 0, AV_BPRINT_SIZE_AUTOMATIC); > // 1. call internal print function, with &buf > // ... > // 2. provide output to caller > if (!av_bprint_is_compl

Re: [FFmpeg-devel] [PATCH 25/35] avutil/opt: add av_opt_to_string

2021-06-10 Thread Diederick C. Niehorster
(NB: I have reorganized your reply a bit to make it for me to respond to) On Wed, Jun 9, 2021 at 1:54 PM Nicolas George wrote: > > The critical part is the API of the new public function, because this we > cannot fix later. > > Unfortunately, to get a good API, you will not be able to reuse the >

Re: [FFmpeg-devel] [PATCH 25/35] avutil/opt: add av_opt_to_string

2021-06-09 Thread Nicolas George
Diederick C. Niehorster (12021-06-08): > The guts of this function is unchanged from av_opt_get, just moved > here, should i address this in this patch, or is it a separate issue? > Happy to do either. The critical part is the API of the new public function, because this we cannot fix later. Unfo

Re: [FFmpeg-devel] [PATCH 25/35] avutil/opt: add av_opt_to_string

2021-06-08 Thread Diederick C. Niehorster
On Tue, Jun 8, 2021 at 4:32 PM Nicolas George wrote: > > Diederick Niehorster (12021-06-08): > Please wrap this. Will do. > > -int av_opt_get(void *obj, const char *name, int search_flags, uint8_t > > **out_val) > > +static int print_option(void* dst, enum AVOptionType type, int > > search_fla

Re: [FFmpeg-devel] [PATCH 25/35] avutil/opt: add av_opt_to_string

2021-06-08 Thread Nicolas George
Diederick Niehorster (12021-06-08): > This function allows formatting an option value stored in a double (such as > the min and max fields of an AVOption, or min_value and max_value of an > AVOptionRange) properly, e.g. 1 for a AV_OPT_TYPE_PIXEL_FMT -> yuyv422. > Useful when printing more info a

[FFmpeg-devel] [PATCH 25/35] avutil/opt: add av_opt_to_string

2021-06-07 Thread Diederick Niehorster
This function allows formatting an option value stored in a double (such as the min and max fields of an AVOption, or min_value and max_value of an AVOptionRange) properly, e.g. 1 for a AV_OPT_TYPE_PIXEL_FMT -> yuyv422. Useful when printing more info about an option than just its value. Usage wi