Re: [FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-03-07 Thread Niklas Haas
On Tue, 05 Mar 2024 11:00:02 +0100 Anton Khirnov wrote: > I prefer consistency here, otherwise the decoder authors have to choose > which function to use, and they are often not aware of the precise > implications of thise choice. Better to always use just one function. Regardless of my personal

Re: [FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-03-07 Thread Anton Khirnov
Quoting James Almer (2024-03-07 13:25:07) > I wouldn't. It adds an extra layer of abstraction for no real gain. The gain is simpler API. What's the gain in forcing decoder authors to call a different function to accomplish the same task, just because frame threading happens to be used. > And the

Re: [FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-03-07 Thread James Almer
On 3/7/2024 9:18 AM, Anton Khirnov wrote: Quoting Andreas Rheinhardt (2024-03-07 12:19:28) Anton Khirnov: Quoting Andreas Rheinhardt (2024-03-04 14:36:09) Anton Khirnov: From: Niklas Haas For consistency, even though this cannot be overriden at the packet level. --- libavcodec/mpeg12dec.c

Re: [FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-03-07 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-07 12:19:28) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2024-03-04 14:36:09) > >> Anton Khirnov: > >>> From: Niklas Haas > >>> > >>> For consistency, even though this cannot be overriden at the packet > >>> level. > >>> --- > >>> libavcodec/mpeg12dec.c |

Re: [FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-03-07 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-04 14:36:09) >> Anton Khirnov: >>> From: Niklas Haas >>> >>> For consistency, even though this cannot be overriden at the packet >>> level. >>> --- >>> libavcodec/mpeg12dec.c | 18 ++ >>> 1 file changed, 10 insertions(+), 8 dele

Re: [FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-03-05 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-04 14:36:09) > Anton Khirnov: > > From: Niklas Haas > > > > For consistency, even though this cannot be overriden at the packet > > level. > > --- > > libavcodec/mpeg12dec.c | 18 ++ > > 1 file changed, 10 insertions(+), 8 deletions(-) > > > >

Re: [FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-03-04 Thread Andreas Rheinhardt
Anton Khirnov: > From: Niklas Haas > > For consistency, even though this cannot be overriden at the packet > level. > --- > libavcodec/mpeg12dec.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c > index

[FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-03-04 Thread Anton Khirnov
From: Niklas Haas For consistency, even though this cannot be overriden at the packet level. --- libavcodec/mpeg12dec.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 3a2f17e508..aa116336dd 100644 ---