Re: [FFmpeg-devel] [PATCH 212/217] avcodec/snow: Fix race in ff_snow_common_init()

On Wed, Dec 02, 2020 at 11:45:10PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Wed, Dec 02, 2020 at 05:22:39AM +0100, Andreas Rheinhardt wrote: > >> Commits d49210788b0836d56dd872d517fe73f83b080101 and > >> ee8ce211ead04c8684da0c9c143814e57e9b9eda set the > >> FF_CODEC_CAP_INIT_T

Re: [FFmpeg-devel] [PATCH 212/217] avcodec/snow: Fix race in ff_snow_common_init()

Michael Niedermayer: > On Wed, Dec 02, 2020 at 05:22:39AM +0100, Andreas Rheinhardt wrote: >> Commits d49210788b0836d56dd872d517fe73f83b080101 and >> ee8ce211ead04c8684da0c9c143814e57e9b9eda set the >> FF_CODEC_CAP_INIT_THREADSAFE flag for the Snow encoder resp. decoder; >> yet these codecs init fu

Re: [FFmpeg-devel] [PATCH 212/217] avcodec/snow: Fix race in ff_snow_common_init()

On Wed, Dec 02, 2020 at 05:22:39AM +0100, Andreas Rheinhardt wrote: > Commits d49210788b0836d56dd872d517fe73f83b080101 and > ee8ce211ead04c8684da0c9c143814e57e9b9eda set the > FF_CODEC_CAP_INIT_THREADSAFE flag for the Snow encoder resp. decoder; > yet these codecs init functions aren't threadsafe a

[FFmpeg-devel] [PATCH 212/217] avcodec/snow: Fix race in ff_snow_common_init()

Commits d49210788b0836d56dd872d517fe73f83b080101 and ee8ce211ead04c8684da0c9c143814e57e9b9eda set the FF_CODEC_CAP_INIT_THREADSAFE flag for the Snow encoder resp. decoder; yet these codecs init functions aren't threadsafe at all: ff_snow_common_init() initializes static data, but there is no check