Re: [FFmpeg-devel] [PATCH 21/35] avdevice: capabilities API details no longer public

2021-06-08 Thread Andreas Rheinhardt
Diederick C. Niehorster: > On Tue, Jun 8, 2021 at 1:54 AM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Diederick Niehorster: >>> NB: will break build, makes needed corresponding changes to avformat. >>> >> >> Then said changes should be part of this patch. Patches should be >

Re: [FFmpeg-devel] [PATCH 21/35] avdevice: capabilities API details no longer public

2021-06-07 Thread Diederick C. Niehorster
On Tue, Jun 8, 2021 at 1:54 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Diederick Niehorster: > > NB: will break build, makes needed corresponding changes to avformat. > > > > Then said changes should be part of this patch. Patches should be > logically self-contained and atom

Re: [FFmpeg-devel] [PATCH 21/35] avdevice: capabilities API details no longer public

2021-06-07 Thread Diederick C. Niehorster
On Tue, Jun 8, 2021 at 1:26 AM James Almer wrote: > On 6/7/2021 8:04 PM, Diederick Niehorster wrote: > Instead of removing the struct altogether, just keep its typedef here. > That way the functions below and any libavformat struct can still use > AVDeviceCapabilitiesQuery as an incomplete type.

Re: [FFmpeg-devel] [PATCH 21/35] avdevice: capabilities API details no longer public

2021-06-07 Thread Andreas Rheinhardt
James Almer: > On 6/7/2021 8:04 PM, Diederick Niehorster wrote: >> NB: will break build, makes needed corresponding changes to avformat. >> >> Signed-off-by: Diederick Niehorster >> --- >>   libavdevice/avdevice.c | 34 -- >>   libavdevice/avdevice.h | 42 +--

Re: [FFmpeg-devel] [PATCH 21/35] avdevice: capabilities API details no longer public

2021-06-07 Thread Andreas Rheinhardt
Diederick Niehorster: > NB: will break build, makes needed corresponding changes to avformat. > Then said changes should be part of this patch. Patches should be logically self-contained and atomic; this is not the same as splitting by file/library. But that is a moot point: James already told y

Re: [FFmpeg-devel] [PATCH 21/35] avdevice: capabilities API details no longer public

2021-06-07 Thread James Almer
On 6/7/2021 8:04 PM, Diederick Niehorster wrote: NB: will break build, makes needed corresponding changes to avformat. Signed-off-by: Diederick Niehorster --- libavdevice/avdevice.c | 34 -- libavdevice/avdevice.h | 42 +

[FFmpeg-devel] [PATCH 21/35] avdevice: capabilities API details no longer public

2021-06-07 Thread Diederick Niehorster
NB: will break build, makes needed corresponding changes to avformat. Signed-off-by: Diederick Niehorster --- libavdevice/avdevice.c | 34 -- libavdevice/avdevice.h | 42 +- libavdevice/internal.h | 33 ++