Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-18 Thread Lukasz Marek
On 18 November 2014 17:06, Stefano Sabatini wrote: > > >>+av_bprint_finalize(&bprint, NULL); > > >>+return ret; > > >>+} > > > > > >This will print alias options as well. This was my solution: > > > > > I'm not sure it is always safe. Options with the same offset m

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-18 Thread Stefano Sabatini
On date Wednesday 2014-11-12 22:32:04 +0100, Lukasz Marek encoded: > On 12.11.2014 17:45, Stefano Sabatini wrote: > >On date Tuesday 2014-11-11 21:24:45 +0100, Lukasz Marek encoded: > >>On 11.11.2014 17:19, Stefano Sabatini wrote: > >>>We have already av_get_opt() which serializes the value. Also w

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-12 Thread Lukasz Marek
On 12.11.2014 17:45, Stefano Sabatini wrote: On date Tuesday 2014-11-11 21:24:45 +0100, Lukasz Marek encoded: On 11.11.2014 17:19, Stefano Sabatini wrote: We have already av_get_opt() which serializes the value. Also we should probably escape the values. I saw that function, but don't remembe

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-12 Thread Stefano Sabatini
On date Tuesday 2014-11-11 21:24:45 +0100, Lukasz Marek encoded: > On 11.11.2014 17:19, Stefano Sabatini wrote: > >We have already av_get_opt() which serializes the value. Also we should > >probably escape the values. > > I saw that function, but don't remember why I didn't use. I was > wrong obvi

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-11 Thread Lukasz Marek
On 11.11.2014 17:19, Stefano Sabatini wrote: We have already av_get_opt() which serializes the value. Also we should probably escape the values. I saw that function, but don't remember why I didn't use. I was wrong obviously. BTW, I found few bugs in it, sent separate patch for it. Updated pa

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-11 Thread Stefano Sabatini
On date Tuesday 2014-11-11 08:31:24 +0100, Lukasz Marek encoded: > TODO: bump minor version, update doc/APIchanges > > Function allows to create string containing object's serialized options. > Such string may be passed back to av_set_options_string() in order to restore > options. > > Signed-of

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 08:31:24AM +0100, Lukasz Marek wrote: > TODO: bump minor version, update doc/APIchanges > > Function allows to create string containing object's serialized options. > Such string may be passed back to av_set_options_string() in order to restore > options. > > Signed-off-b

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-11 Thread Stefano Sabatini
On date Tuesday 2014-11-11 11:02:32 +0100, wm4 encoded: > On Tue, 11 Nov 2014 08:31:24 +0100 > Lukasz Marek wrote: > > > TODO: bump minor version, update doc/APIchanges > > > > Function allows to create string containing object's serialized options. > > Such string may be passed back to av_set_o

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-11 Thread wm4
On Tue, 11 Nov 2014 08:31:24 +0100 Lukasz Marek wrote: > TODO: bump minor version, update doc/APIchanges > > Function allows to create string containing object's serialized options. > Such string may be passed back to av_set_options_string() in order to restore > options. > > Signed-off-by: Lu

[FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-10 Thread Lukasz Marek
TODO: bump minor version, update doc/APIchanges Function allows to create string containing object's serialized options. Such string may be passed back to av_set_options_string() in order to restore options. Signed-off-by: Lukasz Marek --- libavutil/opt.c| 135 +