Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-26 Thread Michael Niedermayer
On Tue, Dec 26, 2017 at 10:20:23AM +0800, Misty De Meo wrote: > I originally left this patch alone since it was another person's > commit; I can squash the fixes for that into this commit if you > prefer, though. no commit in a patchset should knowingly introduce a bug. That would make git bisect

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-26 Thread Michael Niedermayer
On Tue, Dec 26, 2017 at 10:24:07AM +0800, Misty De Meo wrote: > On Tue, Dec 26, 2017 at 8:42 AM, Michael Niedermayer > wrote: > > returning errors from the parse function will cause assertion failure at: > > > > Assertion index > -0x2000 failed at libavcodec/parser.c:185 > > > > [...] > > Wha

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-26 Thread Misty De Meo
I originally left this patch alone since it was another person's commit; I can squash the fixes for that into this commit if you prefer, though. On Tue, Dec 26, 2017 at 8:39 AM, Michael Niedermayer wrote: > On Mon, Dec 25, 2017 at 10:28:30AM +0800, mi...@brew.sh wrote: >> From: Maxim Poliakovski

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-25 Thread Misty De Meo
On Tue, Dec 26, 2017 at 8:42 AM, Michael Niedermayer wrote: > returning errors from the parse function will cause assertion failure at: > > Assertion index > -0x2000 failed at libavcodec/parser.c:185 > > [...] What would be the preferred way to handle that? ___

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-25 Thread Misty De Meo
On Tue, Dec 26, 2017 at 8:39 AM, Michael Niedermayer wrote: > This fails to build without the next patch I originally left this patch alone since it was another person's commit; I can squash the fixes for that into this commit if you prefer, though. ___

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-25 Thread Michael Niedermayer
On Mon, Dec 25, 2017 at 10:28:30AM +0800, mi...@brew.sh wrote: > From: Maxim Poliakovski > > --- > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/atrac3plus_parser.c | 153 > + > libavformat/mpeg.c

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-25 Thread Michael Niedermayer
On Mon, Dec 25, 2017 at 10:28:30AM +0800, mi...@brew.sh wrote: > From: Maxim Poliakovski > > --- > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/atrac3plus_parser.c | 153 > + > libavformat/mpeg.c

[FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-24 Thread misty
From: Maxim Poliakovski --- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/atrac3plus_parser.c | 153 + libavformat/mpeg.c | 27 +++- 4 files changed, 181 insertions(+), 1 deletion(-) create mod