Re: [FFmpeg-devel] [PATCH 2/6] lavc: split LSCR decoder out of PNG decoder

2021-02-20 Thread James Almer
On 2/16/2021 5:24 PM, Anton Khirnov wrote: It shares very little code with pngdec, so keeping them together only makes the code harder to read. --- libavcodec/Makefile | 2 +- libavcodec/lscrdec.c | 279 +++ libavcodec/png.h | 5 + libavcodec/

Re: [FFmpeg-devel] [PATCH 2/6] lavc: split LSCR decoder out of PNG decoder

2021-02-16 Thread Paul B Mahol
I do not like this. On Tue, Feb 16, 2021 at 9:26 PM Anton Khirnov wrote: > It shares very little code with pngdec, so keeping them together only > makes the code harder to read. > --- > libavcodec/Makefile | 2 +- > libavcodec/lscrdec.c | 279 +++ > li

[FFmpeg-devel] [PATCH 2/6] lavc: split LSCR decoder out of PNG decoder

2021-02-16 Thread Anton Khirnov
It shares very little code with pngdec, so keeping them together only makes the code harder to read. --- libavcodec/Makefile | 2 +- libavcodec/lscrdec.c | 279 +++ libavcodec/png.h | 5 + libavcodec/pngdec.c | 174 +-- 4 fi