Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:39, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 12:47:45PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) >>> ret = AVERROR_INVALIDDATA; >>>

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:37, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 12:47:45PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) >>> ret = AVERROR_INVALIDDATA; >>>

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:31, Michael Niedermayer wrote: > all done locally, Thanks, patch is OK then. > some of this code is btw not tested by fate Yes, the FFM1 code path is not tested by FATE. Personally I think it would make more sense to remove support for FFM1 than adding a FATE test for it. The c

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 12:47:45PM +0100, Andreas Cadhalpun wrote: > On 03.12.2016 00:52, Michael Niedermayer wrote: > > @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) > > ret = AVERROR_INVALIDDATA; > > goto fail; > > } > > -

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 12:47:45PM +0100, Andreas Cadhalpun wrote: > On 03.12.2016 00:52, Michael Niedermayer wrote: > > @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) > > ret = AVERROR_INVALIDDATA; > > goto fail; > > } > > -

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 01:19:05AM +0100, Andreas Cadhalpun wrote: > On 03.12.2016 00:52, Michael Niedermayer wrote: > > This is a bit messy as codecar does not support AVOptions so we need > > to use AVCodecContext where AVOptions are required and copy back and forth. > > > > Signed-off-by: Micha

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) > ret = AVERROR_INVALIDDATA; > goto fail; > } > -codec->width = avio_rb16(pb); > -codec->height = avio_rb16(

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-02 Thread Michael Niedermayer
On Sat, Dec 03, 2016 at 12:57:49AM +0100, Hendrik Leppkes wrote: > On Sat, Dec 3, 2016 at 12:52 AM, Michael Niedermayer > wrote: > > This is a bit messy as codecar does not support AVOptions so we need > > to use AVCodecContext where AVOptions are required and copy back and forth. > > > > ffmenc

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-02 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > This is a bit messy as codecar does not support AVOptions so we need > to use AVCodecContext where AVOptions are required and copy back and forth. > > Signed-off-by: Michael Niedermayer > --- > libavformat/ffmdec.c | 159 > ++

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-02 Thread Hendrik Leppkes
On Sat, Dec 3, 2016 at 12:52 AM, Michael Niedermayer wrote: > This is a bit messy as codecar does not support AVOptions so we need > to use AVCodecContext where AVOptions are required and copy back and forth. > ffmenc can't really write any data that doesn't go into codecpar either, since thats a

[FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-02 Thread Michael Niedermayer
This is a bit messy as codecar does not support AVOptions so we need to use AVCodecContext where AVOptions are required and copy back and forth. Signed-off-by: Michael Niedermayer --- libavformat/ffmdec.c | 159 ++- 1 file changed, 82 insertions(+)