Re: [FFmpeg-devel] [PATCH 2/5] avcodec/h264: change some labels to be macro-local

2017-04-06 Thread Ronald S. Bultje
Hi, On Thu, Apr 6, 2017 at 10:22 AM, James Darnley wrote: > On 2017-04-05 13:41, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, Apr 4, 2017 at 9:53 PM, James Darnley wrote: > > > >> The labels get stripped leading to (slightly) nicer disassembly from > >> objdump. > >> > > [..] > > > >> -j

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/h264: change some labels to be macro-local

2017-04-06 Thread James Darnley
On 2017-04-05 13:41, Ronald S. Bultje wrote: > Hi, > > On Tue, Apr 4, 2017 at 9:53 PM, James Darnley wrote: > >> The labels get stripped leading to (slightly) nicer disassembly from >> objdump. >> > [..] > >> -jz .cycle%1end >> +jz %%skip > > > Can you preserve the leading dot? I don'

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/h264: change some labels to be macro-local

2017-04-05 Thread Ronald S. Bultje
Hi, On Tue, Apr 4, 2017 at 9:53 PM, James Darnley wrote: > The labels get stripped leading to (slightly) nicer disassembly from > objdump. > [..] > -jz .cycle%1end > +jz %%skip Can you preserve the leading dot? I don't mind the %%skip, but please make it .%%skip. Ronald _

[FFmpeg-devel] [PATCH 2/5] avcodec/h264: change some labels to be macro-local

2017-04-04 Thread James Darnley
The labels get stripped leading to (slightly) nicer disassembly from objdump. --- libavcodec/x86/h264_idct.asm | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/x86/h264_idct.asm b/libavcodec/x86/h264_idct.asm index 878ff02..dde40e9 100644 --