Re: [FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-25 Thread Andreas Cadhalpun
On 25.05.2015 23:44, Michael Niedermayer wrote: > On Mon, May 25, 2015 at 11:22:32PM +0200, Andreas Cadhalpun wrote: >> On 25.05.2015 21:38, Michael Niedermayer wrote: >>> On Mon, May 25, 2015 at 05:25:18PM +0200, Andreas Cadhalpun wrote: >>> [...] >>> mov.c |7 +++ 1 file change

Re: [FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-25 Thread Michael Niedermayer
On Mon, May 25, 2015 at 11:22:32PM +0200, Andreas Cadhalpun wrote: > On 25.05.2015 21:38, Michael Niedermayer wrote: > > On Mon, May 25, 2015 at 05:25:18PM +0200, Andreas Cadhalpun wrote: > > [...] > > > >> mov.c |7 +++ > >> 1 file changed, 7 insertions(+) > >> 7ff306f094f2ecd47b720deb20

Re: [FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-25 Thread Andreas Cadhalpun
On 25.05.2015 21:38, Michael Niedermayer wrote: > On Mon, May 25, 2015 at 05:25:18PM +0200, Andreas Cadhalpun wrote: > [...] > >> mov.c |7 +++ >> 1 file changed, 7 insertions(+) >> 7ff306f094f2ecd47b720deb20ea318c24efaf4d >> 0002-mov-reject-zero-bytes_per_frame-with-non-zero-sample.pat

Re: [FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-25 Thread Michael Niedermayer
On Mon, May 25, 2015 at 05:25:18PM +0200, Andreas Cadhalpun wrote: [...] > mov.c |7 +++ > 1 file changed, 7 insertions(+) > 7ff306f094f2ecd47b720deb20ea318c24efaf4d > 0002-mov-reject-zero-bytes_per_frame-with-non-zero-sample.patch > From 42c8b0c216b39fd2cb8b329669737ce771ecdd20 Mon Sep

Re: [FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-25 Thread Andreas Cadhalpun
On 25.05.2015 18:31, Michael Niedermayer wrote: > On Mon, May 25, 2015 at 05:25:18PM +0200, Andreas Cadhalpun wrote: >> On 24.05.2015 19:23, Michael Niedermayer wrote: >>> ISO/IEC 14496-12:2012(E) says the field is unsigned so it cannot be >>> negative >>> >>> 8.7.4.2 Syntax >>> aligned(8) class

Re: [FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-25 Thread Michael Niedermayer
On Mon, May 25, 2015 at 05:25:18PM +0200, Andreas Cadhalpun wrote: > On 24.05.2015 19:23, Michael Niedermayer wrote: > > On Sun, May 24, 2015 at 03:21:25PM +0200, Andreas Cadhalpun wrote: > >> mov.c |5 + > >> 1 file changed, 5 insertions(+) > >> 199a14800f0d79aa85b8dc01c2c1dc2743c3fb0d

Re: [FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-25 Thread Andreas Cadhalpun
On 24.05.2015 19:23, Michael Niedermayer wrote: > On Sun, May 24, 2015 at 03:21:25PM +0200, Andreas Cadhalpun wrote: >> mov.c |5 + >> 1 file changed, 5 insertions(+) >> 199a14800f0d79aa85b8dc01c2c1dc2743c3fb0d >> 0001-mov-check-for-negative-stsc-count.patch >> From 1d66ce9f96ccd4e130837

Re: [FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-24 Thread Michael Niedermayer
On Sun, May 24, 2015 at 03:21:25PM +0200, Andreas Cadhalpun wrote: > On 24.05.2015 00:46, Michael Niedermayer wrote: > > On Sun, May 24, 2015 at 12:04:23AM +0200, Andreas Cadhalpun wrote: > > >> +if (!sample->size) { > >> +av_log(s, AV_LOG_ERROR, "sample size is zero\n"); > >> +

Re: [FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-24 Thread Andreas Cadhalpun
On 24.05.2015 00:46, Michael Niedermayer wrote: > On Sun, May 24, 2015 at 12:04:23AM +0200, Andreas Cadhalpun wrote: >> +if (!sample->size) { >> +av_log(s, AV_LOG_ERROR, "sample size is zero\n"); >> +return AVERROR_INVALIDDATA; >> +} > > this would cause failure to demux f

Re: [FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-24 Thread Yusuke Nakamura
2015-05-24 7:04 GMT+09:00 Andreas Cadhalpun < andreas.cadhal...@googlemail.com>: > Without this the mov demuxer can return a large number of empty packets. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/mov.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/mov

Re: [FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-23 Thread Michael Niedermayer
On Sun, May 24, 2015 at 12:04:23AM +0200, Andreas Cadhalpun wrote: > Without this the mov demuxer can return a large number of empty packets. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/mov.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/mov.c b/libavfor

[FFmpeg-devel] [PATCH 2/4] mov: check for positive sample->size

2015-05-23 Thread Andreas Cadhalpun
Without this the mov demuxer can return a large number of empty packets. Signed-off-by: Andreas Cadhalpun --- libavformat/mov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index f6f07be..a6290d1 100644 --- a/libavformat/mov.c +++ b/libavformat/m