Re: [FFmpeg-devel] [PATCH 2/4] libavformat/tcp: Added an option to reuse sockets

2017-11-07 Thread Jeyapal, Karthick
>On 11/7/17, 10:45 AM, "Jeyapal, Karthick" wrote: > >>On 11/3/17, 9:44 PM, "Aman Gupta" wrote: >> >>I recently implemented keepalive support in the hls demuxer, and have been >>using it with a lot of success. See my patchset: >>http://ffmpeg.org/pipermail/ffmpeg-devel/2017-October/217353.html >>

Re: [FFmpeg-devel] [PATCH 2/4] libavformat/tcp: Added an option to reuse sockets

2017-11-06 Thread Jeyapal, Karthick
>On 11/3/17, 9:44 PM, "Aman Gupta" wrote: > >I recently implemented keepalive support in the hls demuxer, and have been >using it with a lot of success. See my patchset: >http://ffmpeg.org/pipermail/ffmpeg-devel/2017-October/217353.html > >Aman Thanks a lot for your excellent suggestion. I was n

Re: [FFmpeg-devel] [PATCH 2/4] libavformat/tcp: Added an option to reuse sockets

2017-11-03 Thread Aman Gupta
On Fri, Nov 3, 2017 at 4:10 AM, Jeyapal, Karthick wrote: > >On 11/3/17, 2:18 PM, "Nicolas George" wrote: > > >I strongly oppose this: we do not want new global state. > I also agree. I am open to suggestions, and I would be happy re-implement > this feature without new global state. > > >Also, I

Re: [FFmpeg-devel] [PATCH 2/4] libavformat/tcp: Added an option to reuse sockets

2017-11-03 Thread Jeyapal, Karthick
>On 11/3/17, 2:18 PM, "Nicolas George" wrote: >I strongly oppose this: we do not want new global state. I also agree. I am open to suggestions, and I would be happy re-implement this feature without new global state. >Also, I am very doubtful about the feature itself. It is public, and as >such

Re: [FFmpeg-devel] [PATCH 2/4] libavformat/tcp: Added an option to reuse sockets

2017-11-03 Thread Nicolas George
Le tridi 13 brumaire, an CCXXVI, Karthick J a écrit : > +static TCPSocket *first_socket = NULL; > +avpriv_lock_avformat(); > +socket->next = first_socket; > +first_socket = socket; > +avpriv_unlock_avformat(); I strongly oppose this: we do not want new global state. Also, I am

Re: [FFmpeg-devel] [PATCH 2/4] libavformat/tcp: Added an option to reuse sockets

2017-11-03 Thread Hendrik Leppkes
On Fri, Nov 3, 2017 at 9:27 AM, Karthick J wrote: > --- > doc/protocols.texi | 4 ++ > libavformat/tcp.c | 150 > > libavformat/tcp.h | 27 ++ > libavformat/utils.c | 2 + > 4 files changed, 183 insertions(+) > create mode 1

[FFmpeg-devel] [PATCH 2/4] libavformat/tcp: Added an option to reuse sockets

2017-11-03 Thread Karthick J
--- doc/protocols.texi | 4 ++ libavformat/tcp.c | 150 libavformat/tcp.h | 27 ++ libavformat/utils.c | 2 + 4 files changed, 183 insertions(+) create mode 100644 libavformat/tcp.h diff --git a/doc/protocols.texi b/doc/proto