On Wed, Jul 30, 2014 at 11:44:47PM +0200, Nicolas George wrote:
> Also deprecate adding a NULL frame to mark EOF.
>
> TODO APIchanges entry, version bump.
>
> Signed-off-by: Nicolas George
> ---
> libavfilter/buffersrc.c | 40 ++--
> libavfilter/buffersrc.h |
Le duodi 12 thermidor, an CCXXII, Derek Buitenhuis a écrit :
> Yeah, why should you have to explain the reason for a change in
> a review of that change? How silly. I should just divine the reason
> why. I guess we don't count as "everyone".
To review a change, the minimum is to read it. The answe
Also deprecate adding a NULL frame to mark EOF.
TODO APIchanges entry, version bump.
Signed-off-by: Nicolas George
---
libavfilter/buffersrc.c | 40 ++--
libavfilter/buffersrc.h | 15 +++
2 files changed, 45 insertions(+), 10 deletions(-)
diff --
On 7/30/2014 6:10 PM, Nicolas George wrote:
> This is tiring. Everyone knows it already and it has been explained numerous
> times.
Yeah, why should you have to explain the reason for a change in
a review of that change? How silly. I should just divine the reason
why. I guess we don't count as "ev
Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
> Demuxers and decoding don't return such an end PTS, so why should
> filters? Demuxers apparently use the frame duration to time the last
> frame, so why not use that in lavfi too? (Demuxers also report the
> total length, but that is probably not us
On Wed, 30 Jul 2014 19:10:04 +0200
Nicolas George wrote:
> Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
> > You never explained what's wrong with it.
>
> This is tiring. Everyone knows it already and it has been explained numerous
> times.
>
> THERE IS NO TIMESTAMP FOR THE END OF STREAM.
Yo
Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
> You never explained what's wrong with it.
This is tiring. Everyone knows it already and it has been explained numerous
times.
THERE IS NO TIMESTAMP FOR THE END OF STREAM.
Is it enough, or do I have to waste more time explaining how that makes the
On Wed, 30 Jul 2014 10:37:12 +0200
Nicolas George wrote:
> Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
> > The libavfilter API
> > for EOF is ok,
>
> No, it is not.
You never explained what's wrong with it.
> > So if you're not actua
Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
>The libavfilter API
> for EOF is ok,
No, it is not.
> So if you're not actually fixing anything
I am.
> What wrong result?
See my first answer when you started this bikeshedding.
Reg
On Wed, 30 Jul 2014 00:13:38 +0200
Nicolas George wrote:
> Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
> > I asked for the reason of the API change. What's the purpose of the API
> > change, if the "deprecated" method is supported forever anyway?
>
> What's the purpose of deprecating gets()
Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
> I asked for the reason of the API change. What's the purpose of the API
> change, if the "deprecated" method is supported forever anyway?
What's the purpose of deprecating gets() in favour of fgets() if the
deprecated function is supported forever
On Thu, 24 Jul 2014 15:49:33 +0200
Nicolas George wrote:
> Le sextidi 6 thermidor, an CCXXII, wm4 a écrit :
> > No, you can't do this.
>
> Yes, I can.
>
> > It breaks compatibility with Libav;
>
> No, it does not. Removing it would break compatibility. Deprecating it does
> nothing.
>
> > als
On Thu, Jul 24, 2014 at 03:39:43PM +0200, Nicolas George wrote:
> Also deprecate adding a NULL frame to mark EOF.
>
> TODO APIchanges entry, version bump.
>
[...]
> diff --git a/libavfilter/buffersrc.h b/libavfilter/buffersrc.h
> index ea34c04..28ca545 100644
> --- a/libavfilter/buffersrc.h
> +++
Le sextidi 6 thermidor, an CCXXII, wm4 a écrit :
> No, you can't do this.
Yes, I can.
> It breaks compatibility with Libav;
No, it does not. Removing it would break compatibility. Deprecating it does
nothing.
> also what's even the purpose of this (API) change?
Fixing a long-standing issue, se
On Thu, 24 Jul 2014 15:39:43 +0200
Nicolas George wrote:
> Also deprecate adding a NULL frame to mark EOF.
No, you can't do this. It breaks compatibility with Libav; also what's
even the purpose of this (API) change?
> TODO APIchanges entry, version bump.
>
> Signed-off-by: Nicolas George
> -
Also deprecate adding a NULL frame to mark EOF.
TODO APIchanges entry, version bump.
Signed-off-by: Nicolas George
---
libavfilter/buffersrc.c | 40 ++--
libavfilter/buffersrc.h | 15 +++
2 files changed, 45 insertions(+), 10 deletions(-)
diff --
16 matches
Mail list logo
